chore: Remove useAccountManagement hook and fix some restricted user UI
#12223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
added
Clean Up
Restricted User Access
This reverts commit 5b6a537.
bnussman-akamai
requested review from
dmcintyr-akamai,
abailly-akamai and
hasyed-akamai
and removed request for
a team
Cloud Manager UI test results🎉 593 passing tests on test run #11 ↗︎
|
dmcintyr-akamai
approved these changes
May 16, 2025
hasyed-akamai
approved these changes
May 19, 2025
hasyed-akamai
pushed a commit
to hasyed-akamai/manager
that referenced
this pull request
May 20, 2025
…r UI (linode#12223) * initial clean up * clean up unnessesary notices * clean up * add safety to grants fetch to fix e2e * Revert "add safety to grants fetch to fix e2e" This reverts commit 5b6a537. * fix up cypress tests * remove check for longview landing notice * fix cypress test * remove `add_buckets` grant because it does not exist? * fix * Added changeset: `add_buckets` from `GlobalGrantTypes` * Added changeset: Inconsistent restricted user notices on landing pages * Added changeset: Remove `useAccountManagement` hook --------- Co-authored-by: Banks Nussman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
useAccountManagementabstraction in favor of more raw/direct hooks (useAccount,useProfile, etc...)useIsObjMultiClusterEnabledhook to reduce some code duplicationadd_bucketsgrant because as far as I can tell, it doesn't even exist in the API 🪣M3-7680's description. We only need to disable the Create buttons with a tooltip message. No Noticed required as far as I understandPreview 📷
Removed notice on Volumes Landing
Removed notice on Images Landing
How to test 🧪
Prerequisites
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅