-
Notifications
You must be signed in to change notification settings - Fork 379
refactor: [M3-9656] - [Akamai Design System] Label Component #12224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-9656] - [Akamai Design System] Label Component #12224
Conversation
…ctor/M3-9656-v2
…ctor/M3-9656-v2
…ctor/M3-9656-v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks this seems to work as expected where tested and no regressions spotted on overall styles ✅
Approving pending addressing the token specificity comment
':hover': { | ||
color: theme.palette.primary.main, | ||
fill: theme.palette.primary.main, | ||
stroke: theme.palette.primary.main, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use icon tokens for the various states
…ctor/M3-9656-v2
…ctor/M3-9656-v2
…ctor/M3-9656-v2
…ctor/M3-9656-v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Erik - didn't observe any regressions.
Cloud Manager UI test results🎉 605 passing tests on test run #10 ↗︎
|
Description 📝
This PR refactors the Label component to the new Akamai Design System. Since we do not have an actual
<Label />
component, the work in this PR addresses instances in which we utilize the<TextField />
component and take advantage of thelabel
prop to assign a label for the form control.Changes 🔄
Typography.Label.Bold.L
Typography.Label.Bold.S
left
orright
of the text.labelTooltipIconPosition
allows developers to set where the<TooltipIcon />
is positioned relative to its label.right
is the default value.labelTooltipIconSize
allows developers to set the size of the<TooltipIcon />
, it also sets the font size for the label.small
is the default value.theme.palette.primary.main
with icon token styles for the various states.Preview 📷
How to test 🧪
Verification steps
labelTooltipIconPosition
andlabelTooltipIconSize
light
anddark
mode styles.Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅