Skip to content

upcoming: [M3-9785, M3-9788] - Added NodeBalacer Table and replace Linodes with Resources #12232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

hasyed-akamai
Copy link
Contributor

@hasyed-akamai hasyed-akamai commented May 16, 2025

Description

  • This PR adds a NodeBalancer Table section under the Subnet table present in VPC Details.
  • This PR replaces the Linodes text with Resources text.

Changes

  • Introduced a new NodeBalancer Table section under the Subnet table present in VPC Details to display associated NodeBalancer information.
  • This PR replaces the Linodes text with Resources text.
  • Added unit test for the NodeBalancer Table Section.

Target Release Date

N/A

Preview

Before After
Before After
Before After
Before After
Before After
Before After

How to Test

🛠 Prerequisites

  • Add the required customer tags in Admin (mentioned in the ticket).
  • Enable the VPC feature flag in Cloud Manager (CM) (mentioned in the ticket).

🧪 Option 1: Using API

  • Create a NodeBalancer via API and associate it with the created VPC (mentioned in the ticket).
  • Go to the VPC Details page (on this PR’s branch) and verify that the NodeBalancer Table section appears under the Subnet table with the correct information.
  • Verify the Linodes text in VPC Landing table column VPC Summary section VPC Subnet table column has been replaced with the Resources.

🧪 Option 2: Using UI

  • Check out this PR that enables NodeBalancer creation with VPC support in the UI.
  • Create a NodeBalancer with a VPC using that UI.
  • Return to this PR’s branch, navigate to the VPC Details page, and verify that the NodeBalancer Table section appears under the Subnet table with the correct information.
  • Verify the Linodes text in VPC Landing table column VPC Summary section VPC Subnet table column has been replaced with the Resources.
Author Checklists

As an Author, I considered:

  • Self-review
  • Contribution guidelines
  • Small, focused PR
  • Changeset added if needed
  • Tests added or updated
  • No sensitive info
  • Feature flag if needed
  • Reproduction steps
  • Docs updated if needed
  • Mobile and a11y support

Before moving from Draft to Open:

  • All unit tests passing
  • TypeScript compiles
  • Linting passes

@hasyed-akamai hasyed-akamai self-assigned this May 16, 2025
@hasyed-akamai hasyed-akamai added the NB-VPC Relating to NodeBalancer-VPC integration label May 16, 2025
@hasyed-akamai hasyed-akamai force-pushed the M3-9785-M3-9788-add-nodebalancer-table-and-replace-linodes-with-resources branch from 7b5cd7e to 01176b5 Compare May 16, 2025 08:35
@hasyed-akamai hasyed-akamai force-pushed the M3-9785-M3-9788-add-nodebalancer-table-and-replace-linodes-with-resources branch from b249cec to 4c0cdbb Compare May 19, 2025 09:04
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #5 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing591 Passing5 Skipped118m 3s

Details

Failing Tests
SpecTest
access-key.e2e.spec.tsCloud Manager Cypress Tests→object storage access key end-to-end tests » object storage access key end-to-end tests

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorage/access-key.e2e.spec.ts"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NB-VPC Relating to NodeBalancer-VPC integration
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

2 participants