test: [M3-9595] - Firewall create page for restricted users #12237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcintyr-akamai
requested review from
jdamore-linode,
hana-akamai and
coliu-akamai
and removed request for
a team
bnussman-akamai
changed the title
Cloud Manager UI test results🎉 595 passing tests on test run #2 ↗︎
|
coliu-akamai
approved these changes
May 16, 2025
There was a problem hiding this comment.
thanks @dmcintyr-akamai! approving pending Linode Interfaces banner issue is addressed
Comment on lines
+184
to
+187
| ui.buttonGroup | ||
| .findButtonByTitle('Create Firewall') | ||
| .should('be.visible') | ||
| .should('be.disabled'); |
There was a problem hiding this comment.
I'm seeing that when Linode interfaces is enabled, the button group may be hidden depending on screensize, making the test fail:
We could either
- add scrollIntoView() -
ui.buttonGroup.findButtonByTitle('Create Firewall').scrollIntoView() - mock the Linode interfaces feature flag to be false (to hide the info banner)
| /* | ||
| * - Verifies that restricted user cannot create firewall on landing page | ||
| */ | ||
| it('create firewall is disabled on landing page', () => { |
There was a problem hiding this comment.
Suggested change
| it('create firewall is disabled on landing page', () => { | |
| it('confirms the create button is disabled on the FirewallLanding page', () => { |
| /* | ||
| * - Verifies that restricted user cannot create firewall in drawer | ||
| */ | ||
| it('create firewall drawer is disabled', () => { |
There was a problem hiding this comment.
Suggested change
| it('create firewall drawer is disabled', () => { | |
| it('confirms the Create Firewall drawer is disabled', () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Add test for firewall create page for restricted users on packages/manager/cypress/e2e/core/firewalls/create-firewall.spec.ts.
Changes 🔄
Verify that 'Create Firewall' button is disabled on landing page (/firewalls) and drawer (/firewalls/create). Inputs within drawer should all be disabled as well.
How to test 🧪
pnpm run cy:run -s cypress/e2e/core/firewalls/create-firewall.spec.ts
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅