Skip to content

test: [M3-9596] - VPC tests for restricted user #12238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dmcintyr-akamai
Copy link
Contributor

@dmcintyr-akamai dmcintyr-akamai commented May 16, 2025

Description 📝

Add tests in packages/manager/cypress/e2e/core/vpc/vpc-create.spec.ts to verify that restricted user cannot "Create VPC" on landing or create page.

Changes 🔄

Tests for routes on /vpcs and /vpcs/create. Added data-testid to form in VPCCreate.tsx to make it easier to validate form inputs in cypress.

How to test 🧪

pnpm run cy:run -s cypress/e2e/core/vpc/vpc-create.spec.ts

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@dmcintyr-akamai dmcintyr-akamai requested review from a team as code owners May 16, 2025 14:28
@dmcintyr-akamai dmcintyr-akamai requested review from jdamore-linode, dwiley-akamai and hasyed-akamai and removed request for a team May 16, 2025 14:28
@bnussman-akamai bnussman-akamai changed the title test [M3-9596]: Vpc tests for restricted user test: [M3-9596] - VPC tests for restricted user May 16, 2025
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes locally & in CI ✅

Copy link
Contributor

@hasyed-akamai hasyed-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Verified: passes both locally and in CI

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager May 19, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 595 passing tests on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing595 Passing4 Skipped114m 34s

@dmcintyr-akamai dmcintyr-akamai merged commit ff3951c into linode:develop May 19, 2025
35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

4 participants