poc: [M3-9996, M3-10048] - Assigning alert definitions (beta) to a Linode during creation
#12248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the Linode details page
pmakode-akamai
added
the
ACLP Integration
pmakode-akamai
commented
May 20, 2025
...ges/manager/src/features/CloudPulse/Alerts/ContextualView/AlertInfoActionTableCreateFlow.tsx
Outdated
Show resolved
Hide resolved
...ges/manager/src/features/CloudPulse/Alerts/ContextualView/AlertInfoActionTableCreateFlow.tsx
Outdated
Show resolved
Hide resolved
pmakode-akamai
changed the title
* Merge edit & create logic in action table * make components flexible * update handler func * type correction * optimize state updates * remove unused func * update type * refactor & cleanup
Contributor
|
A bit concerned about the headers here -
|
Contributor
|
Overall looks good to me, pending @nikhagra-akamai and @venkymano-akamai review |
pmakode-akamai
force-pushed
the
poc/M3-9996
branch
from
9f2e358 to
90123d7
Compare
pmakode-akamai
changed the title
nikhagra-akamai
approved these changes
Jun 10, 2025
Contributor
nikhagra-akamai
left a comment
nikhagra-akamai
left a comment
There was a problem hiding this comment.
looks good to me
pmakode-akamai
changed the title
beta) to a Linode during creation
Contributor
@pmakode-akamai can you please elaborate on what these product requirements are? |
Contributor
Author
@jdamore-linode Yea, Create Flow logic is like:
|
jaalah-akamai
approved these changes
Jun 13, 2025
packages/manager/src/features/Linodes/LinodeCreate/utilities.ts
Outdated
Show resolved
Hide resolved
pmakode-akamai
added
Approved
Collaborator
Cloud Manager UI test results🎉 659 passing tests on test run #21 ↗︎
|
This was referenced Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
An alternative way to ensure alerts are assigned only during the Linode creation process, with RHF integrated to support Create Linode form flow
Important
Note
Additional Optionssection and display Legacy Alerts (read-only) on Create Linode page #12355Changes 🔄
betaAlerts) to a Linode during creationCreateLinodeRequesttype inapiv4packagealertsinCreateLinodeSchemaTarget release date 🗓️
N/A
Preview 📷
How to test 🧪
Prerequisites
MSWand theACLP Integrationfeature flagVerification steps
systemanduseralerts)undefinedor not present or excluded in legacy modeAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅