Merge Master -> Develop #12853
Merged
Merge Master -> Develop #12853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0.74.0, UI version v0.20.0, Utilities version v0.8.0, Queries version v0.13.0, Shared version v0.8.0
Co-authored-by: Connie Liu <[email protected]>
…#12817) * upcoming: [DI-26678] - Firewall dimension filters customization for Alerts * upcoming: [DI-26678] - Mocks for testing * add changeset * upcoming: [DI-26678] - Fix typo * upcoming: [DI-26678] - Tidying up the RenderAlertsMetricAndDimensions component * upcoming: [DI-26678] - updated serverHandler for mock testing * upcoming: [DI-26678] - remove commented code in alerts factory, mock more linodes with ap-west region * upcoming: [DI-26678] - destructuring dimension object in isCheckRequired util * upcoming: [DI-26678] - removing unnecessary prop drilling by importing from constants * remove unused import * upcoming: [DI-26678] - fixing the default error message bug * upcoming: [DI-26678] - using a prop interface for the resolvedDimensionValue util * removing changelog
* [DI-26731] - Alerts contextual view enhancement (#12730) * [DI-26371] - Update handler, reset state, update query * [DI-26371] - Update useffect * [DI-26371] - update mutation hook * [DI-26371] - Fix mutation query hook * [DI-26371] - Fix mutation query hook * [DI-26731] - Add comments * [DI-26731] - Add changeset * [DI-26731] - Fix saved state issue * fix: [M3-10266] - Add automatic redirect for empty paginated Access Keys pages (#12598) * fix: [M3-10266] - OBJ Pagination Redirects * Added changeset: Add automatic redirect for empty paginated Access Keys pages * Add todo comment --------- Co-authored-by: Jaalah Ramos <[email protected]> * upcoming: [DI-26793] - Legend row label shown as per group by order (#12742) * upcoming: [DI-26793] - Update logic to show legend rows based on the group by order * Added changeset * Fixed typecheck failures * upcoming: [DPS-34039] Add actions in Streams list (#12645) * upcoming: [M3-10486] - Update dual-stack labeling in VPC Create (#12746) ## Description 📝 Copy adjustments to the VPC Create flow as requested by Daniel ## How to test 🧪 ### Prerequisites (How to setup test environment) - Pull this PR and point to devcloud (ensure your account has vpc ipv6 customer tag) ### Verification steps (How to verify changes) - [ ] Ensure the VPC IPv6 feature flag is enabled and your account has the VPC Dual Stack account capability - [ ] Go to the VPC Create page - [ ] You should see the updated label changes `IP Stack` and `(dual-stack)` * upcoming: [M3-10485] - Update dual-stack labeling in LKE cluster create (#12754) * Update copy for cluster create dual stack section * Update Cypress test * Added changeset: Update dual-stack labeling for LKE-E clusters in create cluster flow * Update unit test * test: [M3-7763] - Account for parallelization in Cypress test result summary duration (#12765) * Report Cypress test duration of slowest runner * Added changeset: Fix Cypress test result summary duration accuracy * test: [M3-10490] - Add error handling test coverage for LKE-E Phase 2 (BYO VPC, IP Stack) (#12755) * Add test spec for API error handling * Add test case for surfacing client-side validation on VPC field * Restructure test hierarchy and add test for field errors * Fix failures not caught when cherry picking from wrong branch * Added changeset: Add Cypress error handling test coverage for LKE-E Phase 2 (BYO VPC, IP Stack) * Fix test failures from merging in develop * [DI-26971] - Add no region info msg for nodebalancer and firewall (#12759) * [DI-26971] - Add no region info msg for nodebalancer and firewall * [DI-26971] - Correct nodebalancer msg * [DI-26971] - Update msgs * [DI-26971] - Remove duplicate * [DI-26971] - Add changeset --------- Co-authored-by: Nikhil Agrawal <[email protected]> * chore: [UIE-9124] Improve `usePermissions` hook type safety (#12732) * improve usePermissions type safety and cleanup accout landing routing * oops not ready to do this yet * Added changeset: Improve usePermissions hook type safety * cleanup * feedback @aaleksee-akamai * feedback @corya-akamai * feedback @aaleksee-akamai * fix: [M3-10496] - Fix LKE jumping UI on HA Control Plane (#12768) * fix jumping * Added changeset: Jumping UI on LKE Create HA Control Plane when enabling Akamai App Platform * Update packages/manager/src/features/Kubernetes/CreateCluster/HAControlPlane.tsx Co-authored-by: Banks Nussman <[email protected]> * add margin left --------- Co-authored-by: Banks Nussman <[email protected]> * fix: [UI-8803] - IAM Cross browser AssignedRoles entities chips truncation (#12720) * fix some * improve ellipsis pattern * cleanup * cleanup * Added changeset: IAM - Cross browser AssignedRoles entities chips truncation * feat: [UIE-9055] - IAM RBAC: change docs links (#12743) * feat: [UIE-9055] - IAM RBAC: change docs links * Added changeset: IAM RBAC: change docs links to be relevant to content on page * test: [M3-10433] - Test for empty string in numeric input validation (#12769) * numeric input validation test * verify toggle buttons are not disabled by error * Added changeset: Test for empty string in numeric input validation * test for full error msg * test: [M3-9717] - Fix LKE Create Smoke Test Flake (#12738) * M3-9717 Fix LKE Create Smoke Test Flake * Added changeset: Fix LKE Create Smoke Test Flake * test: [M3-10489] - Add Cypress integration test to confirm no LKE-E Phase 2 options visible to standard LKE cluster create flow (#12770) * Add test coverage for standard flow, no phase 2 options * Add changeset * Fix errors * Improve comment * test: [M3-10366] - Add Cypress LKE-E 'phase2Mtc' feature flag smoke tests (#12773) * Move shared utils to lke util file * Add smoke test file for LKE-Enterprise * Add coverage for LKE details flow; clean up * Delete old spec file * Add a TODO comment for M3-10365 * Make naming scheme and jsdocs comments consistent * Added changeset: Add Cypress LKE-E 'phase2Mtc' feature flag smoke tests * Move constant to the correct file * Clean up an unneeded mock * Mock requests that require Kubernetes Enterprise capability * feat: [M3-10324] - Add type-to-confirm to Images (#12740) * support type to confirm on Images * fix up cypress test and loading states * remove question mark from dialog title * add unit test for image row fix * fix type-safety issue * Added changeset: Type-to-confirm to Image deletion dialog --------- Co-authored-by: Banks Nussman <[email protected]> * fix:[M3-10481]- Fix Autocomplete undefined value issues - Part 1 (#12706) * Create debug-M3-9877.yml * Update debug-M3-9877.yml * Update debug-M3-9877.yml * Update debug-M3-9877.yml * Update debug-M3-9877.yml * Update debug-M3-9877.yml * Update debug-M3-9877.yml * Update debug-M3-9877.yml * Update debug-M3-9877.yml * Update debug-M3-9877.yml * Update debug-M3-9877.yml * Remove debug .yml file * Fix autocompletes * Update TwoStepRegion * Revert change to LinodeSelect.tsx * Use 'distributed-ALL' as default in TwoStepRegion.tsx * Add PowerActionsDialogOrDrawer.tsx * Added changeset: Replace undefined with null in Autocomplete values to fix MUI errors * Update MaintenancePolicySelect type --------- Co-authored-by: dmcintyr-akamai <[email protected]> * upcoming: [DPS-34041] Add actions in Destinations list (#12749) * upcoming: [DPS-34041] Add actions in Destinations list * upcoming: [DPS-34041] CR changes 1 --------- Co-authored-by: Mariah Jacobs <[email protected]> * Change: [UIE-9059] - Volumes RBAC permissions (#12744) * adapters + volumes landing * Action menu * remaining instances * fix units * oops the mapping! * cleanup * remove wrong check * changesets * feedback @bnussman-akamai * first round of feedback * feedback 2 * missing grant hooks * tech-story: [M3-10364] - MSW CRUD: Add custom grants to profile preset to prevent type error when using restricted profile preset (#12756) * where are we going with this * something like this?? p1 * add back in service tool worker changes * combine profile and grants preset * Added changeset: MSW CRUD: Fix type error when using custom restricted profile preset and add grants preset support * rename things * more renaming * missed some renaming * fix: [M3-9469] - Reset selected region when switching between Core and Distributed tabs (#12767) ## Description 📝 The Disk Encryption section maintains state from previously selected regions when users switch between Core and Distributed region tabs, showing inconsistent copy, tooltips, and checkbox states until a new region is selected from the current tab. This is because Disk Encryption state is tied to selected region rather than active region tab. When the tab changes without region selection, the component doesn't reset. > [!NOTE] > I tried adding unit tests for this but could not figure out why the tests were failing but the UI is working as expected. Joe is also stumped. ## Changes 🔄 - Clear the region when the region tab changes * feat: [M3-10378] - Show Node Pool firewalls in Node Pool footers (#12779) * Add firewall to node pool footer * Add id and make it copyable * Add missing conditional for enterprise; update unit tests * Do not show 0 firewall; standardize copy tooltip behavior * Only show copyable id if label is also shown; otherwise link id * Added changeset: Linked Node Pool firewall in Node Pool footer for LKE-E clusters * Fix copy tooltip - don't include ID: * Fix test failure * test: [M3-9871] - Fix Linode resize test failures (#12727) * M3-9871 Fix Linode resize test failures * Added changeset: Fix Linode resize test failures * feat: [M3-10039M, M3-10382] - Configure Kubernetes Node Pool Drawer (#12710) * setup initial drawer and form components * add more fields to the new drawer * handle nodepool label properly throughout LKE * add feature flag and cluster tier logic * begin unit testing * add an e2e-like unit test * support tags * fix typo in the unit test comment * fix up ResizeNodePoolDrawer unit test to account for node pool label change in drawer title * fix unit test after adding tag support * change tags select label to just be `Tags` * ensure error is surfaced * keep the word `Plan` in drawer headers * update unit test to account for re-adding the `Plan` suffix to drawer titles * update version select logic to only include valid versions * improve unit test * use v4beta PUT endpoint so new fields actually work * Added changeset: Configure Node Pool Drawer to Kubernetes Cluster details page * Added changeset: Support for Node Pool `label` field * Added changeset: Use `v4beta` API endpoint for `updateNodePool` * fix spelling in comment * hide label & tag fields becuasse they lack PDT commitment * finish up comments * one more comment * Apply suggestions from code review Co-authored-by: Mariah Jacobs <[email protected]> * change changeset to be an upcoming feature * use shared `NodePoolConfigOptions` component @mjac0bs * work on error surfacing * restore inline validation, hopefully it works * `firewall_id` validation is working, but could use some clean up * undo unnessesary validation change * Revert "undo unnessesary validation change" This reverts commit baa45ee. * fix double save issue * clean up * fix form label issues in theme * don't allow user to select default firewall once one has been set * improve validation message * fix label html issue * unit test `getNodePoolVersionOptions` * lint * address feedback regarding `useNodePoolDisplayLabel` * make node pool firewall_id bahavior more forwards compatible with upcoming api changes * add comments --------- Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: Mariah Jacobs <[email protected]> * upcoming: [M3-10523] - Fix and extend ACLP-supported region Linode mock examples (#12747) * Correct ACLP-supported region Linode mocks * Add example 3 in the mocks * Add comments * Added changeset: Fix and extend ACLP-supported region Linode mock examples * feat: [UIE-9141] - IAM RBAC: add perm check for nodebalancer landing (#12780) * feat: [UIE-9141] - IAM RBAC: add perm check for nodebalancer * Added changeset: IAM RBAC: This PR implements IAM RBAC permissions for NodeBalancer * fix test and add changeset * upcoming: [M3-10532] - Disable legacy interface selection in Linode Interface UI when creating Linode from backups (#12772) * disable legacy interfaces when creat ing from backup * tooltip for vpc legacy flow * minor updates * something like this? * changeset * whoops didn't save + add test * tooltip when disabled * update tooltip * no selection when disabled * add test case * this feels really weird ngl * address feedback * this seems more legit * remove stray console * [UIE-9148] - IAM / RBAC - Support permission segmentation for LA (#12764) * Do the deed * hook logic * fix and improve test * fix MaintenancePolicy permissions * improve hook logic based on feedback * feedback @hana-akamai * revert API changes * changesets * tests + improved & cleaned up logic * test: [M3-10568] - Fix failing `linode-storage.spec.ts` delete test following API release (#12794) * Fix failing test following API release, fix test docs and improve test name * Added changeset: Fix disk deletion test following API release changes * new: [STORIF-80] Volume summary page created. (#12757) * new: [STORIF-80] Volume summary page created. * Added changeset: Volume details page * Update packages/manager/src/features/Volumes/VolumeDetails/VolumeEntityDetails/VolumeEntityDetailBody.tsx Co-authored-by: Connie Liu <[email protected]> --------- Co-authored-by: Connie Liu <[email protected]> * [DI-26876] - Add missing props and enhance utils for firewalls contextual view (#12760) * [DI-26876] - Add missing props and enahnce utils for firewalls contextual view * [DI-26876] - revert * [DI-26876] - dont send undefined in metrics call in contextual view for optional filters * [DI-26876] - keep checks at the final processing fn * [DI-26876] - Pr comment * [DI-26876] - Add changeset * [DI-26876] - remove temporary changes --------- Co-authored-by: Nikhil Agrawal <[email protected]> * upcoming: [DI-26469] - TextField character limit validations in Alerts and Metrics (#12771) * fix: [DI-26469] - TextField 100 character limit validations in Alerts and Metrics * add changeset --------- Co-authored-by: Mariah Jacobs <[email protected]> Co-authored-by: Nikhil Agrawal <[email protected]> * upcoming: [DI-26718] - change aggregation function label (#12787) * upcoming: [DI-26718] - change aggregation function label * add changeset * fix: [M3-10570] - Profile preferences across sessions (#12795) * update useMutatePreferences * Added changeset: Profile preferences across sessions * feedback * fix more section * refactor: [M3-10574] - Update jspdf (#12797) * Update jspdf * Added changeset: Updated jspdf to 3.0.2 * upcoming: [M3-10379] - Allow Firewall to be configured in the Add Node Pool Drawer (#12793) * initial work to add more config options to add node pool drawer * save changes * remove unnessesary changes * Added changeset: Add Firewall option to the Add Node Pool Drawer for LKE Enterprise Kubernetes Clusters * Added changeset: General Node Pool schema `nodePoolSchema` * Added changeset: Node Pool schemas `CreateNodePoolSchema` and `EditNodePoolSchema` * Added changeset: Update `CreateNodePoolData` to satisfy @linode/validation's `CreateNodePoolSchema`'s type * add some basic unit testing * organize unit tests --------- Co-authored-by: Banks Nussman <[email protected]> * change: [M3-10395] - Pendo Tag selector support: Create Linode > Linode Plan tabs (#12806) * Add tab title to data-pendo-id * Added changeset: Add data-pendo-id attribute to TabbedPanel for Linode Plan tab tracking * upcoming: [M3-10529] - UX feedback: Change /settings to /account-settings and profile/settings to profile/preferences (#12785) * Change settings route to account-settings * Change rounte 'profile/settings' to 'profile/preferences' * Update PrimaryNav.test.tsx * Update Cypress tests to account for account settings route change * Update packages/manager/src/features/TopMenu/UserMenu/UserMenuPopover.tsx Co-authored-by: Mariah Jacobs <[email protected]> * Remove redundant document titles * PR feedback - @coliu-akamai * Added changeset: UX feedback: Change /settings to /account-settings and profile/settings to profile/preferences --------- Co-authored-by: Joe D'Amore <[email protected]> Co-authored-by: Mariah Jacobs <[email protected]> * tests [M3-10513] Fix for flakey test in alerts-listing-page.spec.ts (#12736) * limit cypress scope to fix test * Added changeset: Fix for flakey test in alerts-listing-page.spec.ts * test [M3 9641]: Tests for Host & VM Maintenance Linode details page changes (#12786) * initial commit * Added changeset: Tests for Host & VM Maintenance in Linode create page * remove deprecated tooltip * initial commit * failure test case * Added changeset: Tests for Host & VM Maintenance Linode details page changes * Delete packages/manager/.changeset/pr-12734-tests-1755697767741.md duplicate changeset file * file from wrong pr * refactoring after review * more edits after review * fix: [M3-10567] - The Make a Payment and Add Payment drawers does not close when the browser back button is clicked (#12796) * Fix: Close Make a payment and Add payment drawers when browser back button is clicked * Added changeset: The Make a Payment and Add Payment drawers does not close when the browser back button is clicked * Update packages/manager/.changeset/pr-12796-fixed-1756845120661.md Co-authored-by: Connie Liu <[email protected]> * PR feedback - Billing related test failures --------- Co-authored-by: Connie Liu <[email protected]> * feat: [M3-9853] - Update Linode Config and Rescue Dialog to support new volume count limit (#12791) * being updating types * confirm values sent to backend (sdi) * add some more slots for testing clean this all up fr later * move stuff to constants file * match api limit on our end oops * allow extra devices to be omitted from payload * changeset * switch to type map instead * fix failing test * rescue updates part 1 * should try to remove cast * optionality feedback @bnussman-akamai * Update packages/utilities/src/helpers/createDevicesFromStrings.ts Co-authored-by: Jaalah Ramos <[email protected]> * address feedback simple warn @jaalah-akamai --------- Co-authored-by: Jaalah Ramos <[email protected]> * fix: [M3-10573] - Improve node pool footer layout, fixing overflow due to added Firewall entity (#12798) * Fix overflow and remove extra margin on divider * Move TagCell underneath the footer text * Added changeset: Node Pool footer layout * Address feedback: apply @bnussman-akamai solution to footer overflow * Remove comment * feat: [UIE-9142] - IAM RBAC: perm check nodebalancer summary tab (#12790) * feat: [UIE-9142] - IAM RBAC: perm check nodebalancer summary tab * Added changeset: IAM RBAC: Implements IAM RBAC permissions for NodeBalancer summary tab * feat: [UIE-9150] - IAM RBAC: add a notification banner for Account Settings if user doesn't have permission (#12774) * feat: [UIE-9150] - IAM RBAC: add a message if lack of permissions * Added changeset: Add a notification banner for Account Settings if user doesn't have permission to see * fix e2e tests * fix: [M3-10400] - Improve disabled list option tooltip behavior in selects (#12777) ## Description 📝 Fix an edge-case where disabled list option tooltips do not disappear when the option that triggered the tooltip is no longer in view ## Changes 🔄 - Add an intersection observer so we only show the tooltip if the option is focused _and_ in view ## How to test 🧪 ### Prerequisites (How to setup test environment) - Go to a page with a region select such as the Linode Create page - Turn on the legacy MSW to mock a disabled region option ### Reproduction steps (How to reproduce the issue, if applicable) - [ ] On another branch or develop, hover over a disabled region option and scroll the container so the option is out of view - [ ] The tooltip still displays ### Verification steps (How to verify changes) - [ ] Checkout this PR or PR preview link - [ ] Hover over a disabled region option and scroll the container so the option is out of view - [ ] The tooltip should not display when out of view * upcoming: [DI-26883] - Added scope selection dropdown in create and edit alert definition form (#12745) * upcoming: [DI-26883] - Added scope selection in create & edit alert form * upcoming: [DI-26883] - Added regions in edit & create alert type interface * upcoming: [DI-26883] - Added constants messages * upcoming: [DI-26883] - Added scope & regions in alert details page * upcoming: [DI-26883] - Added disabled scope dropdown in edit alert definition page * upcoming: [DI-26883] - Updated region filter logic * upcoming: [DI-26883] - Updated AlertsResources component to have optional default value * upcoming: [DI-26883] - Added regions alert definition utils * upcoming: [DI-26883] - Updated alert definition schema to include scope and regions * upcoming: [DI-26883] - Added disabled property to entity scope select component * upcoming: [DI-26883] - Updated test cases * upcoming: [DI-26883] - Updated mock data * upcoming: [DI-26883] - Added scope content renderer for alert details * Added changeset * upcoming: [DI-26883] - Updated logic to scroll to top if page changed * fixed typecheck issue * [DI-26876] - Select default region in firewalls contextual view (#12805) * [DI-26876] - Select default region in firewalls contextual view * [DI-26876] - Save preferences in centralized view for linode region * [DI-26876] - Add changeset * [DI-26876] - Resolve comments * [DI-26876] - Remove temporary changes done for review/testing * tests [M3-9638]: Tests for Host & VM Maintenance in Linode create page (#12734) * initial commit * Added changeset: Tests for Host & VM Maintenance in Linode create page * remove deprecated tooltip * refactoring after review * refactoring after review * refactor: [M3-10584] - Remove unused LKE-E related code from LinodeConfigDialog (#12812) * cleanup * Added changeset: Unused LKE-E related code from `LinodeConfigDialog` * Cloud version v1.150.0, API v4 version v0.148.0, Validation version v0.74.0, UI version v0.20.0, Utilities version v0.8.0, Queries version v0.13.0, Shared version v0.8.0 * Update package version * Update changelog * Update packages/manager/CHANGELOG.md Co-authored-by: Connie Liu <[email protected]> * upcoming: [DI-26678] - Alert Firewall dimension filters customization (#12817) * upcoming: [DI-26678] - Firewall dimension filters customization for Alerts * upcoming: [DI-26678] - Mocks for testing * add changeset * upcoming: [DI-26678] - Fix typo * upcoming: [DI-26678] - Tidying up the RenderAlertsMetricAndDimensions component * upcoming: [DI-26678] - updated serverHandler for mock testing * upcoming: [DI-26678] - remove commented code in alerts factory, mock more linodes with ap-west region * upcoming: [DI-26678] - destructuring dimension object in isCheckRequired util * upcoming: [DI-26678] - removing unnecessary prop drilling by importing from constants * remove unused import * upcoming: [DI-26678] - fixing the default error message bug * upcoming: [DI-26678] - using a prop interface for the resolvedDimensionValue util * removing changelog --------- Co-authored-by: Ankita <[email protected]> Co-authored-by: Jaalah Ramos <[email protected]> Co-authored-by: Jaalah Ramos <[email protected]> Co-authored-by: Nikhil Agrawal <[email protected]> Co-authored-by: mduda-akamai <[email protected]> Co-authored-by: Hana Xu <[email protected]> Co-authored-by: Mariah Jacobs <[email protected]> Co-authored-by: jdamore-linode <[email protected]> Co-authored-by: Alban Bailly <[email protected]> Co-authored-by: Connie Liu <[email protected]> Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: bill-akamai <[email protected]> Co-authored-by: aaleksee-akamai <[email protected]> Co-authored-by: dmcintyr-akamai <[email protected]> Co-authored-by: cliu-akamai <[email protected]> Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: Purvesh Makode <[email protected]> Co-authored-by: Dmytro Chyrva <[email protected]> Co-authored-by: santoshp210-akamai <[email protected]> Co-authored-by: John Callahan <[email protected]> Co-authored-by: Joe D'Amore <[email protected]>
…endo-id Attribute (#12828) * Update Pendo agent script for staging and prod * Update changelog
…12830) * add feature flag, clean up logic * add tests * update changelog + catch unsaved work * update tests * Update packages/manager/src/features/Linodes/LinodesDetail/LinodeConfigs/utilities.ts Co-authored-by: Banks Nussman <[email protected]> --------- Co-authored-by: Banks Nussman <[email protected]>
…r `view_account_settings` (#12840) * Ensure proper permission mapping for view_account_settings * revert unecessary e2e alterations
…tsettings fix: [M3-10606] - Redirects /settings to /account-settings
This reverts commit 774ae87.
Revert Release v.1.150.0 → Staging
…endo-id Attribute (#12828) * Update Pendo agent script for staging and prod * Update changelog
…12830) * add feature flag, clean up logic * add tests * update changelog + catch unsaved work * update tests * Update packages/manager/src/features/Linodes/LinodesDetail/LinodeConfigs/utilities.ts Co-authored-by: Banks Nussman <[email protected]> --------- Co-authored-by: Banks Nussman <[email protected]>
…r `view_account_settings` (#12840) * Ensure proper permission mapping for view_account_settings * revert unecessary e2e alterations
Release v1.150.0 - release → staging
Release v1.150.0 - staging → master
cpathipa
requested review from
hasyed-akamai and
mjac0bs
and removed request for
a team
Contributor
|
@cpathipa We normally do this from the command line. Was there a reason we opted for a PR this time? 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.