-
Notifications
You must be signed in to change notification settings - Fork 389
feat: [UIE-9685] - Proactive IAM e2e gating #13120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jdamore-linode could you give this some attention when you have a minute? I'd like to avoid a ton of failures once the IAM customer tags get rolled out again. Ideally I'd want to run this PR against a test account with the tag. thx! |
@abailly-akamai just kicked off a run against the account with IAM 👍 |
|
Better than I expected! If I have time this afternoon I'll take a stab at some of these |
|
@jdamore-linode thx! i did another pass but will need your help with the remaining since they seem to be passing locally with my account |
|
@abailly-akamai planning to look at these last few and ideally push fixes this afternoon |
Cloud Manager UI test results🔺 1 failing test on test run #18 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/volumes/attach-volume.spec.ts" |
|||||||||||||||||
|
@jdamore-linode just FYI the latest run was done with it is the plan to add 10k users tomorrow to the pool - unsure if we're at a good place with this PR at this point |
|
@abailly-akamai, nice! I think in that case we're ready to merge whenever you are 👍 not totally sure what happened with that Volume Attach test: at a glance it looks like the attach succeeded as expected but the toast didn't appear. |
Description 📝
This PR adds IAM flag mocking in preparation for the
iam_betacustomer tag to be added to the test accounts.When it fist happened (and since was rolled back), we noticed a wide array of failures related to the handling of the permission endpoints:
https://baker.linode.com/blue/organizations/jenkins/manager%2Fmanager-test/detail/PR-13105/4/tests
While this will have to be handled properly post beta, we want to prevent failures for every run, then progressively fix the tests.
@jdamore-linode - is there a way we can get this particular PR to run with the newly test account that was taken out of rotation? I want to see if I missed anything.
Changes 🔄
Scope 🚢
Upon production release, changes in this PR will be visible to:
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅