Skip to content

Conversation

@abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Nov 20, 2025

Description 📝

This PR adds IAM flag mocking in preparation for the iam_beta customer tag to be added to the test accounts.

When it fist happened (and since was rolled back), we noticed a wide array of failures related to the handling of the permission endpoints:

https://baker.linode.com/blue/organizations/jenkins/manager%2Fmanager-test/detail/PR-13105/4/tests

While this will have to be handled properly post beta, we want to prevent failures for every run, then progressively fix the tests.

@jdamore-linode - is there a way we can get this particular PR to run with the newly test account that was taken out of rotation? I want to see if I missed anything.

Changes 🔄

  • mock iam: enabled as false in failing tests

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@abailly-akamai abailly-akamai marked this pull request as ready for review November 21, 2025 09:20
@abailly-akamai abailly-akamai requested review from a team as code owners November 21, 2025 09:20
@abailly-akamai abailly-akamai requested review from jdamore-linode and removed request for a team November 21, 2025 09:20
@abailly-akamai
Copy link
Contributor Author

@jdamore-linode could you give this some attention when you have a minute? I'd like to avoid a ton of failures once the IAM customer tags get rolled out again. Ideally I'd want to run this PR against a test account with the tag. thx!

@jdamore-linode
Copy link
Contributor

@jdamore-linode could you give this some attention when you have a minute? I'd like to avoid a ton of failures once the IAM customer tags get rolled out again. Ideally I'd want to run this PR against a test account with the tag. thx!

@abailly-akamai just kicked off a run against the account with IAM 👍

@jdamore-linode
Copy link
Contributor

Better than I expected! If I have time this afternoon I'll take a stab at some of these

@abailly-akamai
Copy link
Contributor Author

@jdamore-linode thx! i did another pass but will need your help with the remaining since they seem to be passing locally with my account

@jdamore-linode
Copy link
Contributor

@abailly-akamai planning to look at these last few and ideally push fixes this afternoon

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #18 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing830 Passing11 Skipped42m 11s

Details

Failing Tests
SpecTest
attach-volume.spec.tsCloud Manager Cypress Tests→volume attach and detach flows » attaches a volume to a Linode

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/volumes/attach-volume.spec.ts"

@abailly-akamai
Copy link
Contributor Author

@jdamore-linode just FYI the latest run was done with e2e-pat-prod-2

it is the plan to add 10k users tomorrow to the pool - unsure if we're at a good place with this PR at this point

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Dec 15, 2025
@jdamore-linode
Copy link
Contributor

@abailly-akamai, nice! I think in that case we're ready to merge whenever you are 👍 not totally sure what happened with that Volume Attach test: at a glance it looks like the attach succeeded as expected but the toast didn't appear.

@abailly-akamai abailly-akamai merged commit 823b828 into linode:develop Dec 15, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

4 participants