Skip to content

Conversation

@grevanak-akamai
Copy link
Contributor

@grevanak-akamai grevanak-akamai commented Dec 5, 2025

Description 📝

Under linode network tab, edit button is hidden currently for VPC NAT IPv4 address. As part of this PR, this issue is fixed by showing the button for such IP address row.

Changes 🔄

  • Updated logic to show/hide edit button in IP address row under linode network tab to show the button for VPC NAT IP address as well.

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

December 2025

Preview 📷

Before After
Screenshot 2025-12-05 at 12 21 41 PM Screenshot 2025-12-05 at 12 22 18 PM

How to test 🧪

Prerequisites

Reproduction steps

  • Create Linode
  • Create VPC
  • Assign linode to VPC. Ensure "Allow public IPv4 access (1:1 NAT)" is checked before assigning Linode to VPC
  • Reboot Linode
  • After reboot is completed, switch to network tab under linode details page and under IP addresses table, see that IP address row with type "VPC NAT – IPv4" doesn't have edit RDNS button.

Verification steps

(How to verify changes)

  • Follow above steps and ensure Edit RDNS button is shown for IP address row with type "VPC NAT – IPv4".
  • Ensure no regressions
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@grevanak-akamai grevanak-akamai requested a review from a team as a code owner December 5, 2025 07:07
@grevanak-akamai grevanak-akamai added the Linodes Dealing with the Linodes section of the app label Dec 5, 2025
Copy link
Contributor

@harsh-akamai harsh-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Thanks @grevanak-akamai

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Dec 8, 2025
@grevanak-akamai grevanak-akamai merged commit dc4e474 into linode:develop Dec 15, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Linodes Dealing with the Linodes section of the app

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

3 participants