Skip to content

Conversation

@aaleksee-akamai
Copy link
Contributor

Description 📝

This PR allows users with account_viewer role to see the users table.

Changes 🔄

List any change(s) relevant to the reviewer.

  • Update the permission's check
  • Update tests

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Preview 📷

Before After
with account_viewer role:
image image
without account_viewer role:
image image

How to test 🧪

Prerequisites

(How to setup test environment)

  • use iam account (not-admin) with/without account_viewer role

Reproduction steps

(How to reproduce the issue, if applicable)

  • go to /iam/users

Verification steps

(How to verify changes)

  • Users table is visible if user has view_account permission
  • Action menu options are enabled if user has view_account permission (except the deleting)
  • Action menu (Delete User) is enabled if user has delete_user permission
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix. Code looks good and users are now properly returned for users with view_account permission

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Dec 11, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 6 failing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
6 Failing821 Passing11 Skipped54m 24s

Details

Failing Tests
SpecTest
lke-create.spec.tsCloud Manager Cypress Tests→smoketest for Nvidia Blackwell GPUs in kubernetes/create page→standard tier » enabled feature flag includes blackwells
create-linode-blackwell.spec.tsCloud Manager Cypress Tests→smoketest for Nvidia blackwell GPUs in linodes/create page » disables Blackwells if disabled region selected
create-linode-blackwell.spec.tsCloud Manager Cypress Tests→smoketest for Nvidia blackwell GPUs in linodes/create page » enables Blackwells if enabled region selected
plan-selection.spec.tsCloud Manager Cypress Tests→displays specific linode plans for GPU » Should render divided tables when GPU divider enabled
plan-selection.spec.tsCloud Manager Cypress Tests→displays specific kubernetes plans for GPU » Should render divided tables when GPU divider enabled
create-linode.spec.tsCloud Manager Cypress Tests→Create Linode→End-to-end→By plan type » creates a Premium CPU Linode

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/kubernetes/lke-create.spec.ts,cypress/e2e/core/linodes/create-linode-blackwell.spec.ts,cypress/e2e/core/linodes/plan-selection.spec.ts,cypress/e2e/core/linodes/create-linode.spec.ts"

@aaleksee-akamai aaleksee-akamai merged commit 9263baf into linode:develop Dec 15, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

5 participants