Skip to content

Conversation

@santoshp210-akamai
Copy link
Contributor

Description 📝

Alerts Notification Channels Listing Page with Search, Ordering, Pagination

Changes 🔄

List any change(s) relevant to the reviewer.

  • Created Listing, Table, TableRow components to render the NotificationChannels
  • Search TextField to search over the Notification Channels that filters through the labels
  • Ordering of each header
  • Pagination
  • Logic to scrollToTop on page size and page number changes
  • Tooltip for Alerts header column
  • UTs to test the functionality

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.

Preview 📷

Include a screenshot <img src="" /> or video <video src="" /> of the change.

🔒 Use the Mask Sensitive Data setting for security.

💡 For changes requiring multiple steps to validate, prefer a video for clarity.

Notification_channel_listing.mp4

How to test 🧪

Prerequisites

(How to setup test environment)

  • In mock environment, once the notificationChannels is enabled in aclpAlerting (CloudPulse Alerting) feature flag

Verification steps

(How to verify changes)

  • ...
  • ...
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@santoshp210-akamai
Copy link
Contributor Author

UTs are 350+ lines.

@santoshp210-akamai santoshp210-akamai marked this pull request as ready for review December 11, 2025 14:38
@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Dec 12, 2025
@santoshp210-akamai
Copy link
Contributor Author

Since then failing tests are not part of this PR changes. Will be merging the PR.

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #7 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing830 Passing11 Skipped36m 54s

Details

Failing Tests
SpecTest
clone-linode.spec.tsCloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts"

@santoshp210-akamai santoshp210-akamai merged commit 738f57d into linode:develop Dec 15, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

4 participants