Skip to content

new: STORIF-295 - Condition for showing Volume Metrcis tab updated.#13452

Merged
skulpok-akamai merged 2 commits into
linode:developfrom
dchyrva-akamai:feature/STORIF-295
Mar 5, 2026
Merged

new: STORIF-295 - Condition for showing Volume Metrcis tab updated.#13452
skulpok-akamai merged 2 commits into
linode:developfrom
dchyrva-akamai:feature/STORIF-295

Conversation

@dchyrva-akamai

Copy link
Copy Markdown
Contributor

Description 📝

Added additional check that looks into the list of metrics supported by the Volume's region.

How to test 🧪

  • Run pnpm dev.
  • Navigate to /volumes.
  • Make sure that all the feature flags related to the
    Volume Metrics are enabled.
  • Make sure the ACLP service is available.
  • Select a volume from a region that supports
    Block Storage metrics.
  • Observe Metrics tab button, it should be available
    on the tabs panel.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@dchyrva-akamai dchyrva-akamai marked this pull request as ready for review March 2, 2026 13:57
@dchyrva-akamai dchyrva-akamai requested a review from a team as a code owner March 2, 2026 13:57
import { VolumeDrawers } from '../VolumeDrawers/VolumeDrawers';
import { VolumeDetailsHeader } from './VolumeDetailsHeader';

const BLOCK_STORAGE_METRICS_KEY = 'Block Storage';

@bnussman-akamai bnussman-akamai Mar 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: Maybe we could put this in packages/manager/src/features/Volumes/constants.ts?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, moved, thank you.

@bnussman-akamai bnussman-akamai requested a review from a team March 2, 2026 15:19
@bnussman-akamai bnussman-akamai added the Volumes Relating to Volumes (aka Block Storage) label Mar 2, 2026
@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Mar 2, 2026
@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🔺 4 failing tests on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
4 Failing865 Passing11 Skipped37m 38s

Details

Failing Tests
SpecTest
object-storage.e2e.spec.tsCloud Manager Cypress Tests→object storage end-to-end tests » can create and delete object storage buckets
account-switching.spec.tsCloud Manager Cypress Tests→Parent/Child account switching→From Parent to Child » can search child accounts
account-switching.spec.tsCloud Manager Cypress Tests→Parent/Child account switching→From Child to Parent » can switch from Proxy user back to Parent account user from Billing page
account-switching.spec.tsCloud Manager Cypress Tests→Parent/Child account switching→From Child to Child » can switch to another Child account as a Proxy user

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts,cypress/e2e/core/parentChild/account-switching.spec.ts"

@skulpok-akamai skulpok-akamai merged commit a1a54db into linode:develop Mar 5, 2026
34 of 35 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Volumes Relating to Volumes (aka Block Storage)

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants