Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Terraform data source linode_lke_node_pool to fetch details for a specific LKE node pool by id and cluster_id, along with integration tests and documentation.
Changes:
- Introduces a new framework data source implementation + schema for
linode_lke_node_pool. - Adds integration coverage for basic read + not-found scenarios using new acceptance templates.
- Adds public documentation for the new data source.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| linode/lkenodepool/tmpl/template.go | Exposes template helpers for data source acceptance test configs. |
| linode/lkenodepool/tmpl/data_basic.gotf | Adds acceptance config for a successful data source read. |
| linode/lkenodepool/tmpl/data_cluster_not_found.gotf | Adds acceptance config for invalid cluster lookup. |
| linode/lkenodepool/tmpl/data_nodepool_not_found.gotf | Adds acceptance config for invalid node pool lookup. |
| linode/lkenodepool/framework_models.go | Adds data source state model + parser from API types. |
| linode/lkenodepool/framework_datasource.go | Implements the data source Read logic. |
| linode/lkenodepool/framework_datasource_schema.go | Defines the Terraform schema for the data source. |
| linode/lkenodepool/framework_datasource_test.go | Adds integration tests for the new data source. |
| linode/framework_provider.go | Registers the new data source in the provider. |
| docs/data-sources/lke_node_pool.md | Adds documentation for the new data source. |
| docs/data-sources/lke_cluster.md | Fixes a markdown header formatting issue. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
ezilber-akamai
left a comment
There was a problem hiding this comment.
Looks good overall! I did get the following error when running the test locally:
=== CONT TestAccDataSourceLKENodePool_basic
test_retry.go:82: FATAL: Step 1/3 error: Check failed: Check 4/25 error: data.linode_lke_node_pool.test: Attribute 'disk_encryption' expected "disabled", got "enabled"
test_retry.go:37: Retrying TestAccDataSourceLKENodePool_basic due to failure. (Attempt 1)
test_retry.go:82: FATAL: Step 1/3 error: Check failed: Check 4/25 error: data.linode_lke_node_pool.test: Attribute 'disk_encryption' expected "disabled", got "enabled"
test_retry.go:37: Retrying TestAccDataSourceLKENodePool_basic due to failure. (Attempt 2)
test_retry.go:40: Test failed after 2 attempts
--- FAIL: TestAccDataSourceLKENodePool_basic (377.63s)
ezilber-akamai
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR adds a new,
lke_node_pooldata source.It requires providing two attributes:
id- The Node Pool's ID.cluster_id- The Cluster's ID.Returns details about the specific Node Pool.
✔️ How to Test
To run integrations tests:
make PKG_NAME="lkenodepool" TEST_CASE="TestAccDataSourceLKENodePool_basic" test-intI would like to add another test for enterprise cluster, but I need to have access to the admin panel. But I think it's not required for this PR to be merged if I won't gain the access.