test the timing options if they are supported#39
Conversation
milosmalik
force-pushed
the
basic-timing-options
branch
from
619f58e to
39c854d
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new sanity test for fapolicyd timing options, adding a test configuration and a test script. The review feedback highlights a critical issue where attempting to read the timing report file before stopping the timing run will fail, as the file does not yet exist; it suggests asserting its non-existence instead. Additionally, the header comments in the test script should be updated to correctly describe the test.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
milosmalik
force-pushed
the
basic-timing-options
branch
from
39c854d to
f632d46
Compare
The fapolicyd version 1.5 introduced the following command-line options: * --timing-start * --timing-stop Purpose of this test is to find out if they work as expected. The test performs basic actions (no corner cases, no regressions).
milosmalik
force-pushed
the
basic-timing-options
branch
from
f632d46 to
07520a1
Compare
1 participant
The fapolicyd version 1.5 introduced the following command-line options:
Purpose of this test is to find out if they work as expected. The test performs basic actions (no corner cases, no regressions).