Add test_linux_watchdog: Test if the watchdog resets the device#18
Open
SmithChart wants to merge 1 commit intolinux-automation:masterfrom
Open
Add test_linux_watchdog: Test if the watchdog resets the device#18SmithChart wants to merge 1 commit intolinux-automation:masterfrom
SmithChart wants to merge 1 commit intolinux-automation:masterfrom
Conversation
Signed-off-by: Chris Fiege <cfi@pengutronix.de>
SmithChart
force-pushed
the
test-wdg
branch
from
0be54f6 to
098aeac
Compare
Bastian-Krause
requested changes
Nov 11, 2025
|
|
||
| def test_linux_watchdog(strategy): | ||
| """ | ||
| Check if the system reboots, if we stop feeding the watchdog. |
Member
There was a problem hiding this comment.
Suggested change
| Check if the system reboots, if we stop feeding the watchdog. | |
| Check if the system resets, if we stop feeding the watchdog. |
| """ | ||
| Check if the system reboots, if we stop feeding the watchdog. | ||
|
|
||
| The watchdog is handled by systemd, so stopping systemd should reboot the DUT. |
Member
There was a problem hiding this comment.
Suggested change
| The watchdog is handled by systemd, so stopping systemd should reboot the DUT. | |
| The watchdog is handled by systemd, so stopping systemd should reset the DUT. |
Comment on lines
+103
to
+108
| index, _, _, _ = strategy.console.expect( | ||
| ["STM32 RCC reset reason WDG", TIMEOUT], | ||
| timeout=30, | ||
| ) | ||
| if index != 0: | ||
| raise Exception("Device failed to reboot in time.") |
Member
There was a problem hiding this comment.
What's the benefit compared to..
Suggested change
| index, _, _, _ = strategy.console.expect( | |
| ["STM32 RCC reset reason WDG", TIMEOUT], | |
| timeout=30, | |
| ) | |
| if index != 0: | |
| raise Exception("Device failed to reboot in time.") | |
| strategy.console.expect("STM32 RCC reset reason WDG", timeout=30) |
..?
Comment on lines
+109
to
+113
| strategy.target.activate(strategy.barebox) | ||
| strategy.barebox.run_check("global linux.bootargs.loglevel=loglevel=6") | ||
| strategy.barebox.boot("") | ||
| strategy.barebox.await_boot() | ||
| strategy.target.activate(strategy.shell) |
Member
There was a problem hiding this comment.
You're basically doing the same as the strategy does. I don't think that's a good approach. I would drop all of this (see below how the device can be easily transitioned to a well defined state).
Comment on lines
+114
to
+118
| except Exception as e: | ||
| # With any exception happening in this test we must assume that the device state is tainted. | ||
| # Let's switch it off, so the strategy can reboot the device into a clean state | ||
| strategy.transition(Status.off) | ||
| raise e |
Member
There was a problem hiding this comment.
Suggested change
| except Exception as e: | |
| # With any exception happening in this test we must assume that the device state is tainted. | |
| # Let's switch it off, so the strategy can reboot the device into a clean state | |
| strategy.transition(Status.off) | |
| raise e | |
| finally: | |
| # Let's switch the TAC off, so it reaches a well defined state | |
| strategy.transition("off") |
..and drop the from lxatacstrategy import Status.
Comment on lines
+97
to
+100
| strategy.target.deactivate(strategy.shell) | ||
|
|
||
| # systemd should be feeding the watchdog. let's kill systemd and wait for the watchdog to reset the DUT. | ||
| strategy.console.write(b"kill -11 1\n") # This command will not return, so we can not use shell.run() |
Member
There was a problem hiding this comment.
The upstream BareboxRebootStrategy does this a little different: https://github.com/labgrid-project/labgrid/blob/f63dfd70a5da2c7007ee8c320fa969df2c0bf16e/examples/strategy/bareboxrebootstrategy.py#L95
| assert 10 <= data["cpu_thermal-virtual-0"]["temp1"]["temp1_input"] <= 70 | ||
|
|
||
|
|
||
| def test_linux_watchdog(strategy): |
Member
There was a problem hiding this comment.
Nothing makes sure the device is actually in the shell state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.