[RFC] qdl: introduce allow-fusing parameter #103
+65
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor program_find_bootable_partition() function implementation. Signed-off-by: Igor Opaniuk <[email protected]>
Introduce the --allow-fusing parameter, which must be explicitly set if the "secdata" partition is programmed, as it will lead to irreversible changes (fuses will be blown during the next boot). Signed-off-by: Igor Opaniuk <[email protected]>
|
@konradybcio @lumag @andersson could you please take a look. thanks! |
lumag
requested changes
May 1, 2025
| @@ -219,6 +219,23 @@ int erase_execute(struct qdl_device *qdl, int (*apply)(struct qdl_device *qdl, s | |||
| return 0; | |||
| } | |||
|
|
|||
| static struct program *program_find_partition(const char *partition) | |||
There was a problem hiding this comment.
Please write somewhat sensible commit message, descring why do you need to perform these changes and/or what kind of refactoring was performed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the
--allow-fusingparameter, which must be explicitly set if thesecdatapartition is programmed, as it will lead to irreversible changes (fuses will be blown during the next boot).