qdl: Allow skipping the firehose step by omitting xml files #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes it is useful to run only the sahara step without running firehose. Allow that by detecting if no xml files are passed. This is mainly useful to mix and match qdl with stock tools like QSaharaServer and fh_loader, in case some combination of these behaves better for a given device. Signed-off-by: Jerry Zhang <[email protected]>
Author
|
Reviews in this chain: |
Author
Collaborator
|
I think we need to combine this feature with the support for then running qdl again, while the device is already in Firehose state. |
|
Isn't this what |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it is useful to run only the sahara step without running
firehose. Allow that by detecting if no xml files are passed.
This is mainly useful to mix and match qdl with stock tools like
QSaharaServer and fh_loader, in case some combination of these
behaves better for a given device.
Signed-off-by: Jerry Zhang [email protected]