qdl: add support for dry run execution #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersson
requested changes
Mar 27, 2025
igoropaniuk
force-pushed
the
dry_run_support
branch
3 times, most recently
from
e3da70f to
2929f09
Compare
igoropaniuk
force-pushed
the
dry_run_support
branch
4 times, most recently
from
9ecd150 to
d921829
Compare
igoropaniuk
changed the title
|
@andersson Thank you for your review. I have addressed all your recently posted comments. Please let me know if there's anything else I need to do. |
|
@konradybcio @lumag could you please take a look |
lumag
reviewed
Apr 28, 2025
| struct qdl_device_sim | ||
| { | ||
| struct qdl_device base; | ||
| }; |
There was a problem hiding this comment.
I think qdl_device_foo should be internal to foo.h
There was a problem hiding this comment.
tbh I don't want to introduce a new header file just for one struct definition. If there are more things to move to a separate header in the future, that will definitely make sense.
There was a problem hiding this comment.
Then just sim.c, if that's the only place where it is used.
Decouple the flashing logic from the underlying type of communication. This is needed for introducing simulation mode, where no real flashing is performed, but firehose packets are used for other tasks, like VIP table generation. Signed-off-by: Igor Opaniuk <[email protected]>
This mode assists in validating the `rawprogram_.xml` and `patch_.xml` files, as well as the Firehose commands that are expected to be sent to the Firehose programmer. Dry run implementation is also expected to be extended for the Digests Table generation required for Firehose Validated Image Programming (VIP). Example of usage: $ qdl --dry-run --serial=0AA94EFD --debug prog_firehose_ddr.elf rawprogram*.xml patch*.xml qdl version v2.1-24-g30ac3a8-dirty This is a dry-run execution of QDL. No actual flashing has been performed waiting for programmer... FIREHOSE WRITE: <?xml version="1.0"?> <data><configure MemoryName="ufs" MaxPayloadSizeToTargetInBytes="1048576" verbose="0" ZLPAwareHost="1" SkipStorageInit="0"/></data> FIREHOSE WRITE: <?xml version="1.0"?> <data><configure MemoryName="ufs" MaxPayloadSizeToTargetInBytes="0" verbose="0" ZLPAwareHost="1" SkipStorageInit="0"/></data> accepted max payload size: 0 FIREHOSE WRITE: <?xml version="1.0"?> <data><program SECTOR_SIZE_IN_BYTES="4096" num_partition_sectors="131072" physical_partition_number="0" start_sector="6" filename="efi.bin"/></data> Signed-off-by: Igor Opaniuk <[email protected]>
igoropaniuk
force-pushed
the
dry_run_support
branch
from
d921829 to
f07a2d3
Compare
|
@lumag all comments addressed (to some extent), please let me know if you have additional comments/objections. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mode assists in validating the
rawprogram_.xmlandpatch_.xmlfiles, as well as the Firehose commands that are expected to be sent to the Firehose programmer.Dry run implementation is also expected to be extended for the Digests Table generation required for Firehose Validated Image Programming (VIP).
Example of usage: