Makefile: prefer mkimage for sunxi images#238
Merged
Conversation
U-Boot's mkimage supports generating Allwinner eGON boot images with the sunxi_egon image type. Prefer that when available, since mkimage is maintained and commonly packaged with U-Boot tools. Keep mksunxiboot as a fallback for setups with older mkimage versions or without mkimage installed. Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
a67519a to
4e98569
Compare
apritzel
approved these changes
May 19, 2026
apritzel
left a comment
Contributor
There was a problem hiding this comment.
Thanks, looks good, and mkimage is indeed the more reliable tool moving forward. Tested by misspelling mkimage and sunxi_egon, to test the fallback paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
U-Boot's mkimage supports generating Allwinner eGON boot images with the sunxi_egon image type. Prefer that when available, since mkimage is maintained and commonly packaged with U-Boot tools.
Keep mksunxiboot as a fallback for setups with older mkimage versions or without mkimage installed.