test: use crypto policy DEFAULT:PQ to enable PQC on el9.7 and later#253
Merged
richm merged 1 commit intolinux-system-roles:mainfrom Jan 16, 2026
Merged
Conversation
Have to enable crypto policy DEFAULT:PQ in order to use post quantum crypto on el9.7 and later. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's GuideExtends the existing certificate test playbook to temporarily enable the DEFAULT:PQ crypto policy on EL9.7+ (and other EL9 derivatives) to support post‑quantum crypto during the test run, then restores the original policy afterward. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The distro/version conditional determining when to adjust crypto-policies is fairly complex; consider extracting it into a clearly named fact (e.g.
__needs_pqc_crypto_policy) to make the intent and future maintenance easier. - Changing the node’s crypto policy without wrapping the change and reset into a single
blockwith analwayssection means a failing test could leave the system inDEFAULT:PQ; consider restructuring so the crypto policy is always reverted even on task failures.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The distro/version conditional determining when to adjust crypto-policies is fairly complex; consider extracting it into a clearly named fact (e.g. `__needs_pqc_crypto_policy`) to make the intent and future maintenance easier.
- Changing the node’s crypto policy without wrapping the change and reset into a single `block` with an `always` section means a failing test could leave the system in `DEFAULT:PQ`; consider restructuring so the crypto policy is always reverted even on task failures.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Author
|
[citest] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have to enable crypto policy DEFAULT:PQ in order to use post quantum crypto
on el9.7 and later.
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Tests: