Skip to content

Comments

test: use crypto policy DEFAULT:PQ to enable PQC on el9.7 and later#253

Merged
richm merged 1 commit intolinux-system-roles:mainfrom
richm:test-el9-pqc-crypto_policy
Jan 16, 2026
Merged

test: use crypto policy DEFAULT:PQ to enable PQC on el9.7 and later#253
richm merged 1 commit intolinux-system-roles:mainfrom
richm:test-el9-pqc-crypto_policy

Conversation

@richm
Copy link
Contributor

@richm richm commented Jan 16, 2026

Have to enable crypto policy DEFAULT:PQ in order to use post quantum crypto
on el9.7 and later.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Tests:

  • Adjust existing certificate tests to set crypto-policies to DEFAULT:PQ on RHEL 9.7+ and equivalent EL9 systems when needed and reset them after test execution.

Have to enable crypto policy DEFAULT:PQ in order to use post quantum crypto
on el9.7 and later.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 16, 2026

Reviewer's Guide

Extends the existing certificate test playbook to temporarily enable the DEFAULT:PQ crypto policy on EL9.7+ (and other EL9 derivatives) to support post‑quantum crypto during the test run, then restores the original policy afterward.

File-Level Changes

Change Details Files
Conditionally enable DEFAULT:PQ crypto policy around the existing-certificate tests for EL9-based systems that require it, ensuring the original crypto policy is restored after tests complete.
  • Add an Ansible block that detects EL9.7+ RHEL or non-RHEL EL9 systems where PQC requires crypto-policies configuration
  • Invoke the fedora.linux_system_roles.crypto_policies role with a null policy to capture the current active crypto policy
  • Store the current crypto policy in a temporary fact for later restoration
  • Invoke the crypto_policies role again to set crypto_policies_policy to DEFAULT:PQ so tests can use PQC
  • Add a post-test task that resets the crypto policy to the previously captured value, guarded so it only runs when a previous policy was recorded
tests/tests_certificate_existing.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The distro/version conditional determining when to adjust crypto-policies is fairly complex; consider extracting it into a clearly named fact (e.g. __needs_pqc_crypto_policy) to make the intent and future maintenance easier.
  • Changing the node’s crypto policy without wrapping the change and reset into a single block with an always section means a failing test could leave the system in DEFAULT:PQ; consider restructuring so the crypto policy is always reverted even on task failures.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The distro/version conditional determining when to adjust crypto-policies is fairly complex; consider extracting it into a clearly named fact (e.g. `__needs_pqc_crypto_policy`) to make the intent and future maintenance easier.
- Changing the node’s crypto policy without wrapping the change and reset into a single `block` with an `always` section means a failing test could leave the system in `DEFAULT:PQ`; consider restructuring so the crypto policy is always reverted even on task failures.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm
Copy link
Contributor Author

richm commented Jan 16, 2026

[citest]

@richm richm merged commit c388c72 into linux-system-roles:main Jan 16, 2026
41 of 43 checks passed
@richm richm deleted the test-el9-pqc-crypto_policy branch January 16, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant