Conversation
Add Fedora 43, remove Fedora 41 from Testing Farm CI Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates Testing Farm CI to drop Fedora 41, add Fedora 43, and align the test matrix and supported platforms list (including Ansible versions) with current Fedora support. Flow diagram for computing supported Fedora platforms in CIflowchart TD
A[Read meta_main meta/main.yml] --> B[Check if galaxy_tags contains fedora]
B -->|yes| C[Add Fedora-42 to supported_platforms]
C --> D[Add Fedora-43 to supported_platforms]
B -->|no| E[Do not add generic Fedora platforms]
A --> F[Check if galaxy_tags contains fedoraN pattern]
F -->|yes| G[Add specific Fedora versions to supported_platforms]
F -->|no| H[No specific Fedora versions added]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider centralizing the Fedora versions and corresponding Ansible versions (used both in
supported_platformsconstruction and the matrix) into a single variable or mapping to avoid duplication and reduce the chance of inconsistencies in future updates.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider centralizing the Fedora versions and corresponding Ansible versions (used both in `supported_platforms` construction and the matrix) into a single variable or mapping to avoid duplication and reduce the chance of inconsistencies in future updates.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Fedora 43, remove Fedora 41 from Testing Farm CI
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Update Testing Farm CI workflow to test against current Fedora releases.
CI: