Skip to content
Draft
Changes from all commits
Commits
Show all changes
151 commits
Select commit Hold shift + click to select a range
3d53bc1
ci: This PR is to trigger periodic CI testing
github-actions[bot] Oct 8, 2023
976d9c1
ci: This PR is to trigger periodic CI testing
github-actions[bot] Oct 9, 2023
0706d1f
ci: This PR is to trigger periodic CI testing
github-actions[bot] Oct 15, 2023
4987df2
ci: This PR is to trigger periodic CI testing
github-actions[bot] Oct 22, 2023
c7d3b99
ci: This PR is to trigger periodic CI testing
github-actions[bot] Oct 29, 2023
0c6d710
ci: This PR is to trigger periodic CI testing
github-actions[bot] Nov 5, 2023
74cf53d
ci: This PR is to trigger periodic CI testing
github-actions[bot] Nov 12, 2023
b34f452
ci: This PR is to trigger periodic CI testing
github-actions[bot] Nov 19, 2023
82487f6
ci: This PR is to trigger periodic CI testing
github-actions[bot] Nov 26, 2023
a0e510f
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 3, 2023
32ff8ef
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 10, 2023
b4d6dd6
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 17, 2023
e50ce4a
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 24, 2023
e6f869e
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 31, 2023
7d83115
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jan 7, 2024
96dc51d
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jan 14, 2024
fd9f58b
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jan 21, 2024
9cc967b
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jan 28, 2024
4d7ee83
ci: This PR is to trigger periodic CI testing
github-actions[bot] Feb 4, 2024
d249da3
ci: This PR is to trigger periodic CI testing
github-actions[bot] Feb 11, 2024
94ab306
ci: This PR is to trigger periodic CI testing
github-actions[bot] Feb 18, 2024
b4c08ee
ci: This PR is to trigger periodic CI testing
github-actions[bot] Feb 25, 2024
8e03345
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 3, 2024
084f242
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 10, 2024
bc59cc8
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 17, 2024
aa7c069
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 24, 2024
0372b06
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 31, 2024
a7940ab
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 7, 2024
a1258c9
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 14, 2024
78039b2
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 21, 2024
e504cc7
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 28, 2024
20a1760
ci: This PR is to trigger periodic CI testing
github-actions[bot] May 5, 2024
5125658
ci: This PR is to trigger periodic CI testing
github-actions[bot] May 12, 2024
a0dc760
ci: This PR is to trigger periodic CI testing
github-actions[bot] May 19, 2024
d351934
ci: This PR is to trigger periodic CI testing
github-actions[bot] May 26, 2024
68c0675
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 2, 2024
8e026f7
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 9, 2024
4fa847f
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 16, 2024
90ac8f1
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 23, 2024
f353f96
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 30, 2024
afbec45
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jul 7, 2024
1df86c0
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jul 14, 2024
dc2ba2c
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jul 21, 2024
24beeb3
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jul 28, 2024
3af6d7c
ci: This PR is to trigger periodic CI testing
github-actions[bot] Aug 4, 2024
8f3f80c
ci: This PR is to trigger periodic CI testing
github-actions[bot] Aug 11, 2024
5680432
ci: This PR is to trigger periodic CI testing
github-actions[bot] Aug 18, 2024
a347509
ci: This PR is to trigger periodic CI testing
github-actions[bot] Aug 25, 2024
54ffd9f
ci: This PR is to trigger periodic CI testing
github-actions[bot] Sep 1, 2024
1160a9d
ci: This PR is to trigger periodic CI testing
github-actions[bot] Sep 8, 2024
14a85c3
ci: This PR is to trigger periodic CI testing
github-actions[bot] Sep 15, 2024
34c805f
ci: This PR is to trigger periodic CI testing
github-actions[bot] Sep 22, 2024
c581072
ci: This PR is to trigger periodic CI testing
github-actions[bot] Sep 29, 2024
acd8594
ci: This PR is to trigger periodic CI testing
github-actions[bot] Oct 6, 2024
3f2a2b2
ci: This PR is to trigger periodic CI testing
github-actions[bot] Oct 13, 2024
f84a697
ci: This PR is to trigger periodic CI testing
github-actions[bot] Oct 20, 2024
ad28cb1
ci: This PR is to trigger periodic CI testing
github-actions[bot] Oct 27, 2024
236e19a
ci: This PR is to trigger periodic CI testing
github-actions[bot] Nov 3, 2024
cb03f32
ci: This PR is to trigger periodic CI testing
github-actions[bot] Nov 10, 2024
fead703
ci: This PR is to trigger periodic CI testing
github-actions[bot] Nov 17, 2024
1ca2ff2
ci: This PR is to trigger periodic CI testing
github-actions[bot] Nov 24, 2024
34ef9ea
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 1, 2024
a1da48e
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 8, 2024
337cd3b
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 15, 2024
3418ea6
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 22, 2024
fe3f77a
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 29, 2024
288974f
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jan 5, 2025
59caa15
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jan 12, 2025
7e02f56
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jan 19, 2025
596f567
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jan 26, 2025
92732ef
ci: This PR is to trigger periodic CI testing
github-actions[bot] Feb 2, 2025
23672b9
ci: This PR is to trigger periodic CI testing
github-actions[bot] Feb 9, 2025
1c858c4
ci: This PR is to trigger periodic CI testing
github-actions[bot] Feb 16, 2025
22db3f7
ci: This PR is to trigger periodic CI testing
github-actions[bot] Feb 23, 2025
dde93a4
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 2, 2025
65d2b70
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 9, 2025
457dd9d
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 16, 2025
4b6024f
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 23, 2025
7ee072e
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 30, 2025
a118cc1
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 6, 2025
a151bf0
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 13, 2025
4c39663
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 20, 2025
332f931
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 27, 2025
77c6c8b
ci: This PR is to trigger periodic CI testing
github-actions[bot] May 4, 2025
0509a74
ci: This PR is to trigger periodic CI testing
github-actions[bot] May 11, 2025
43257f6
ci: This PR is to trigger periodic CI testing
github-actions[bot] May 18, 2025
45da4fa
ci: This PR is to trigger periodic CI testing
github-actions[bot] May 25, 2025
ee39a8f
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 1, 2025
840b19d
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 8, 2025
a5ec4c6
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 15, 2025
bc6a771
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 22, 2025
dca756f
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 29, 2025
194c05c
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jul 6, 2025
8980ecd
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jul 13, 2025
12a6f5a
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jul 20, 2025
576b660
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jul 27, 2025
429d408
ci: This PR is to trigger periodic CI testing
github-actions[bot] Aug 3, 2025
f0be79f
ci: This PR is to trigger periodic CI testing
github-actions[bot] Aug 10, 2025
de2e4bc
ci: This PR is to trigger periodic CI testing
github-actions[bot] Aug 17, 2025
fcf3d29
ci: This PR is to trigger periodic CI testing
github-actions[bot] Aug 24, 2025
9709099
ci: This PR is to trigger periodic CI testing
github-actions[bot] Aug 31, 2025
766e26f
ci: This PR is to trigger periodic CI testing
github-actions[bot] Sep 7, 2025
7bbcf56
ci: This PR is to trigger periodic CI testing
github-actions[bot] Sep 14, 2025
b43672f
ci: This PR is to trigger periodic CI testing
github-actions[bot] Sep 21, 2025
0b77f61
ci: This PR is to trigger periodic CI testing
github-actions[bot] Sep 28, 2025
0bc7660
ci: This PR is to trigger periodic CI testing
github-actions[bot] Oct 5, 2025
becb92a
ci: This PR is to trigger periodic CI testing
github-actions[bot] Oct 12, 2025
b027f37
ci: This PR is to trigger periodic CI testing
github-actions[bot] Oct 19, 2025
312abc9
ci: This PR is to trigger periodic CI testing
github-actions[bot] Oct 26, 2025
f5f735e
ci: This PR is to trigger periodic CI testing
github-actions[bot] Nov 2, 2025
2649e74
ci: This PR is to trigger periodic CI testing
github-actions[bot] Nov 9, 2025
6d624ab
ci: This PR is to trigger periodic CI testing
github-actions[bot] Nov 16, 2025
b213ed8
ci: This PR is to trigger periodic CI testing
github-actions[bot] Nov 23, 2025
a4b15e1
ci: This PR is to trigger periodic CI testing
github-actions[bot] Nov 30, 2025
98ef32d
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 7, 2025
ea147f7
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 14, 2025
5335a5d
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 21, 2025
9850dbe
ci: This PR is to trigger periodic CI testing
github-actions[bot] Dec 28, 2025
1ba3d88
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jan 4, 2026
35b7423
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jan 11, 2026
c0f19ef
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jan 18, 2026
028e622
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jan 25, 2026
505aa4e
ci: This PR is to trigger periodic CI testing
github-actions[bot] Feb 1, 2026
d800b3e
ci: This PR is to trigger periodic CI testing
github-actions[bot] Feb 8, 2026
7567a73
ci: This PR is to trigger periodic CI testing
github-actions[bot] Feb 15, 2026
eb559e9
ci: This PR is to trigger periodic CI testing
github-actions[bot] Feb 22, 2026
4e357dc
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 1, 2026
3e01f9c
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 8, 2026
f896147
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 15, 2026
536423f
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 22, 2026
4fb62b6
ci: This PR is to trigger periodic CI testing
github-actions[bot] Mar 29, 2026
ebebb38
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 5, 2026
d42075f
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 12, 2026
52beca9
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 14, 2026
a8bfce0
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 14, 2026
c1721ef
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 19, 2026
deb3860
ci: This PR is to trigger periodic CI testing
github-actions[bot] Apr 26, 2026
a6f0bb3
ci: This PR is to trigger periodic CI testing
github-actions[bot] May 3, 2026
29ad43b
ci: This PR is to trigger periodic CI testing
github-actions[bot] May 10, 2026
15f833c
ci: This PR is to trigger periodic CI testing
github-actions[bot] May 17, 2026
c2dc268
ci: This PR is to trigger periodic CI testing
github-actions[bot] May 24, 2026
15f90f5
ci: This PR is to trigger periodic CI testing
github-actions[bot] May 31, 2026
18ee64a
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 7, 2026
7a4738f
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 14, 2026
e377e9b
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 21, 2026
5b36195
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jun 28, 2026
04e1eb0
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jul 5, 2026
1a37200
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jul 12, 2026
5adb701
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jul 19, 2026
aecdb37
ci: This PR is to trigger periodic CI testing
github-actions[bot] Jul 26, 2026
f2ec2cd
ci: This PR is to trigger periodic CI testing
github-actions[bot] Aug 2, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions tests/callback_plugins/dump_packages.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
# -*- coding: utf-8 -*-
# Copyright (C) 2023, Red Hat, Inc.
# SPDX-License-Identifier: MIT

from __future__ import absolute_import, division, print_function

__metaclass__ = type

DOCUMENTATION = """
author: Rich Megginson
name: dump_packages
type: aggregate
short_description: dump arguments to package module
description:
- Dump arguments to package module to get list of packages.
- Used in conjunction with CI testing to get the packages used
- with all combinations of: distribution/version/role arguments
- Used to generate lists of packages for ostree image builds.
requirements:
- None
"""

from ansible.plugins.callback import CallbackBase # noqa: E402


class CallbackModule(CallbackBase):
"""
Dump packages.
"""

CALLBACK_VERSION = 2.0
CALLBACK_TYPE = "aggregate"
CALLBACK_NAME = "dump_packages"
# needed for 2.9 compatibility
CALLBACK_NEEDS_WHITELIST = False # wokeignore:rule=whitelist
CALLBACK_NEEDS_ENABLED = False

def __init__(self, *args, **kwargs):
super(CallbackModule, self).__init__(*args, **kwargs)

def v2_runner_on_ok(self, result):
fields = result._task_fields
if (
fields["action"] in ["package", "dnf", "yum"]
and fields["args"].get("state") != "absent"
):
packages = set()
if "invocation" in result._result:
results = [result._result]
elif "results" in result._result and isinstance(
result._result["results"], list
):
results = result._result["results"]
for item in results:

Check failure

Code scanning / CodeQL

Potentially uninitialized local variable

Local variable 'results' may be used before it is initialized.

Copilot Autofix

AI 7 months ago

In general, to fix a “potentially uninitialized local variable” problem, either (1) initialize the variable to a safe default before any conditional assignments or (2) ensure all control-flow paths that reach its use have definitely assigned it (for example, by adding else cases or early returns).

Here, the safest change without altering existing behavior is:

  • Initialize results to an empty list before the if/elif chain.
  • After the chain, only iterate over results if it is non-empty; otherwise, simply skip the loop so no UnboundLocalError can occur.
    This preserves current behavior when results is defined as before, while making the code no-op (rather than crash) in the rare case that neither condition is met.

Concretely in tests/callback_plugins/dump_packages.py:

  • In CallbackModule.v2_runner_on_ok, add results = [] right after packages = set().
  • Wrap the for item in results: loop and subsequent package processing in an if results: guard so it only executes when results has been set to something meaningful.

No new imports or helper methods are required.

Suggested changeset 1
tests/callback_plugins/dump_packages.py

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/tests/callback_plugins/dump_packages.py b/tests/callback_plugins/dump_packages.py
--- a/tests/callback_plugins/dump_packages.py
+++ b/tests/callback_plugins/dump_packages.py
@@ -45,20 +45,22 @@
             and fields["args"].get("state") != "absent"
         ):
             packages = set()
+            results = []
             if "invocation" in result._result:
                 results = [result._result]
             elif "results" in result._result and isinstance(
                 result._result["results"], list
             ):
                 results = result._result["results"]
-            for item in results:
-                pkgs = item["invocation"]["module_args"]["name"]
-                if isinstance(pkgs, list):
-                    for ii in pkgs:
-                        packages.add(ii)
-                else:
-                    packages.add(pkgs)
-            # tell python black that this line is ok
-            # fmt: off
-            self._display.display("lsrpackages: " + " ".join(sorted(list(packages))))
-            # fmt: on
+            if results:
+                for item in results:
+                    pkgs = item["invocation"]["module_args"]["name"]
+                    if isinstance(pkgs, list):
+                        for ii in pkgs:
+                            packages.add(ii)
+                    else:
+                        packages.add(pkgs)
+                # tell python black that this line is ok
+                # fmt: off
+                self._display.display("lsrpackages: " + " ".join(sorted(list(packages))))
+                # fmt: on
EOF
@@ -45,20 +45,22 @@
and fields["args"].get("state") != "absent"
):
packages = set()
results = []
if "invocation" in result._result:
results = [result._result]
elif "results" in result._result and isinstance(
result._result["results"], list
):
results = result._result["results"]
for item in results:
pkgs = item["invocation"]["module_args"]["name"]
if isinstance(pkgs, list):
for ii in pkgs:
packages.add(ii)
else:
packages.add(pkgs)
# tell python black that this line is ok
# fmt: off
self._display.display("lsrpackages: " + " ".join(sorted(list(packages))))
# fmt: on
if results:
for item in results:
pkgs = item["invocation"]["module_args"]["name"]
if isinstance(pkgs, list):
for ii in pkgs:
packages.add(ii)
else:
packages.add(pkgs)
# tell python black that this line is ok
# fmt: off
self._display.display("lsrpackages: " + " ".join(sorted(list(packages))))
# fmt: on
Copilot is powered by AI and may make mistakes. Always verify output.
pkgs = item["invocation"]["module_args"]["name"]
if isinstance(pkgs, list):
for ii in pkgs:
packages.add(ii)
else:
packages.add(pkgs)
# tell python black that this line is ok
# fmt: off
self._display.display("lsrpackages: " + " ".join(sorted(list(packages))))
# fmt: on