Skip to content

wip #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
richm wants to merge 1 commit into from
Closed

wip #233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ansible-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ jobs:
set -euxo pipefail
TOXENV=collection lsr_ci_runtox
coll_dir=".tox/ansible_collections/$LSR_ROLE2COLL_NAMESPACE/$LSR_ROLE2COLL_NAME"
ls -alrtF "$coll_dir"
ls -alrtF "$coll_dir"/meta
Comment on lines +46 to +47

@sourcery-ai sourcery-ai Bot Feb 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 suggestion (security): Consider limiting or gating the verbose directory listings to avoid noisy logs and potential leakage of path details.

These ls -alrtF calls will add a lot of noise to CI logs and may expose environment-specific filesystem details. If this is mainly for debugging, consider guarding them with a flag (e.g., a DEBUG env var) or using a narrower listing like ls "$coll_dir"/meta/meta.* so logs stay focused while still giving you the needed diagnostics.

# cleanup after collection conversion
rm -rf "$coll_dir/.ansible" .tox/ansible-plugin-scan
# ansible-lint action requires a .git directory???
Expand Down
Loading