Skip to content

test: remove unused files - #258

Merged
richm merged 1 commit into
linux-system-roles:mainfrom
richm:remove-unused
Jun 23, 2026
Merged

test: remove unused files#258
richm merged 1 commit into
linux-system-roles:mainfrom
richm:remove-unused

Conversation

@richm

@richm richm commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

We do not use molecule.

The custom requirements are no longer needed.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by CodeRabbit

  • Chores
    • Removed obsolete development configuration files and dependency declarations to streamline project setup and reduce unnecessary scaffolding.

We do not use molecule.

The custom requirements are no longer needed.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm
richm requested a review from ueno as a code owner June 23, 2026 22:26
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: aa75c075-1f7d-4a6d-b531-daa55ccce4bd

📥 Commits

Reviewing files that changed from the base of the PR and between 37ec822 and a74dcc1.

📒 Files selected for processing (4)
  • custom_requirements.txt
  • molecule/default/Dockerfile.j2
  • molecule/default/molecule.yml
  • molecule_extra_requirements.txt
💤 Files with no reviewable changes (4)
  • custom_requirements.txt
  • molecule_extra_requirements.txt
  • molecule/default/Dockerfile.j2
  • molecule/default/molecule.yml

📝 Walkthrough

Walkthrough

Four files have their entire contents removed: the Molecule default scenario configuration (molecule.yml), the Dockerfile Jinja2 template (Dockerfile.j2), custom_requirements.txt, and molecule_extra_requirements.txt. No new content is added to replace any of the deleted lines.

Changes

Cohort / File(s) Summary
Molecule scenario and requirements removal
molecule/default/molecule.yml, molecule/default/Dockerfile.j2, custom_requirements.txt, molecule_extra_requirements.txt
All content removed from each file. molecule.yml previously defined a centos-8 platform with a Galaxy driver and full scenario sequence. Dockerfile.j2 previously contained base image selection and package installation logic. Both requirements files had their SPDX headers and descriptive comments removed.
🚥 Pre-merge checks | ✅ 4 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete; it lacks the required 'Enhancement', 'Reason', 'Result', and 'Issue Tracker Tickets' sections specified in the template. Restructure the description to follow the template by adding explicit sections for Enhancement, Reason, Result, and Issue Tracker Tickets fields.
Description Format ⚠️ Warning PR description does not follow template structure; missing required "Enhancement:" (or "Feature:"), "Reason:", and "Result:" sections from .github/pull_request_template.md. Reformat PR description to include: Enhancement:/Feature: (what changed), Reason: (why), and Result: (outcome) sections following the standard template.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title follows Conventional Commits format with 'test' type and clearly describes the main change of removing unused test configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@richm
richm merged commit 062e226 into linux-system-roles:main Jun 23, 2026
38 checks passed
@richm
richm deleted the remove-unused branch June 23, 2026 22:30
@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@94d31fa). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff           @@
##             main    #258   +/-   ##
======================================
  Coverage        ?   0.00%           
======================================
  Files           ?       1           
  Lines           ?      33           
  Branches        ?       0           
======================================
  Hits            ?       0           
  Misses          ?      33           
  Partials        ?       0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant