Skip to content

Fix property name "class" of ethernet gadget#103

Open
chris2511 wants to merge 1 commit intolinux-usb-gadgets:masterfrom
chris2511:master
Open

Fix property name "class" of ethernet gadget#103
chris2511 wants to merge 1 commit intolinux-usb-gadgets:masterfrom
chris2511:master

Conversation

@chris2511
Copy link

commit 36e71e1
renamed all "class" to "class_" for C++ compatibility. However, the file name in the configfs should remain "class":

openat(AT_FDCWD, "/sys/kernel/config/usb_gadget/g1/functions/rndis.usb0/class_", O_RDONLY|O_LARGEFILE) = -1 ENOENT (No such file or directory)

Reproducible by running the examples:
gadget-rndis-os-desc; show-gadgets

Fixes: commit 36e71e1

commit 36e71e1
renamed all "class" to "class_" for C++ compatibility.
However, the file name in the configfs should remain "class":

  openat(AT_FDCWD, "/sys/kernel/config/usb_gadget/g1/functions/rndis.usb0/class_", O_RDONLY|O_LARGEFILE) = -1 ENOENT (No such file or directory)

Reproducible by running the examples:
  gadget-rndis-os-desc; show-gadgets

Fixes: commit 36e71e1
@einarjon
Copy link

This does fix the rndis module, but the problem remains that all the other gadgets (NCM, ACM, etc) do no have any class/subclass/protocol properties. See issue #102 and #101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants