Fixes for some of the compile warnings (-Wall -pedantic).

[folkertvanheusden]

This PR fixes some of the compile warnings.
examples/gadget-hid.c was just a matter of some casting, examples/gadget-vid-pid-remove.c was a bug, most others were stray ';'.

Two important things:

• the test set complains about 10 failed tests before my changes and also (same) 10 after

• I did not understand container_of and ARRAY_SIZE_SENTINEL

First container_of:

#define container_of(ptr, type, field) ({                               \
                        const typeof(((type *)0)->field) *member = (ptr); \
                        (type *)( (char *)member - offsetof(type, field) ); \
                })

member is assigned the contents of 'ptr' with a typeof but in the line after that, member is casted to char * anyway?

ARRAY_SIZE_SENTINEL: what is it for? It is instantiated 4 times but never referenced. Also it has the 'unused' attribute. So why bother? I disabled (not removed) it for now as compiling it produces warnings about 0-sized arrays.

[mgrzeschik]

I took this partially . Could you rebase. Thanks!

[folkertvanheusden]

done

…

On Tue, Sep 24, 2024 at 11:48 PM Michael Grzeschik ***@***.***> wrote: I took this partially . Could you rebase. Thanks! — Reply to this email directly, view it on GitHub <#84 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUN5IW2ANEMOFEHY4SODUJDZYHMZXAVCNFSM6AAAAABOZGP7OWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZSGQ2DOOJVHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>