-
-
Notifications
You must be signed in to change notification settings - Fork 196
Add kconfig to use blobs on 24.12 boards coreboot configs and proper build output to console #1943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kconfig to use blobs on 24.12 boards coreboot configs and proper build output to console #1943
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JonathonHall-Purism @miczyg1 please review!
Originally posted by @Oessel in #1940 (comment) |
When rebuilding a target after cleaning up the coreboot repo under
Command: Another module not cleaned properly? |
Yes: same issue for files created by patches as for your other comment #1943 (comment) Heads creates some files through patches/* files and therefore why the dev cycles helpers in global Makefile :/ Lines 939 to 950 in 4035abb
The ther Makefile global dev cycles helpers will radically remove more artifacts, and consequently take more time to rebuild rom to be tested :/ The alternative of using helpers is to nuke the heads dir and start fresh from git clone. I have not found better alternatives if patches are not upstreamed, which is one of the many reasons I push so much for patches to be upstreamed. |
Still working on the helper to have patches reversal working properly. |
…ed on git repo now Repro: sudo sed -i 's/# CONFIG_USE_BLOBS is not set/CONFIG_USE_BLOBS=y/g' config/coreboot-* sudo git restore config/coreboot-kgpe-d16_server.config config/coreboot-kgpe-d16_workstation-usb_keyboard.config config/coreboot-kgpe-d16_workstation.config ./docker_repro.sh find ./boards/ -type d | awk -F "/" {'print $3'} | while read board; do make BOARD=$board coreboot.save_in_oldconfig_format_in_place; done Test @miczyg1 hypothesis from linuxboot#1940 (comment) - We use git repo for coreboot 24.12 as opposed to tarball for previous 22.04.01 - 3rdparty microcode git submodule might be empty for some reason if not instructed to be synced by kconfig) - TODO: Review linuxboot#1940 (comment) Signed-off-by: Thierry Laurion <[email protected]>
…O: ") Signed-off-by: Thierry Laurion <[email protected]>
8884abc
to
eaebd8d
Compare
Will be fixed by #1952 separate issue |
Waiting for build to succeed to merge. |
CONFIG_USE_BLOBS=y
in all boards that switched from coreboot 24.02.01 tarball release to coreboot fit repo with 24.12 (race condition introduced under Coreboot version bump 24.02.01 -> 24.12 for most board + Thinkpad T480 addition (coreboot upstream in WiP state) #1908)