Skip to content

fix: Fixed the issue that other account status was abnormal #2280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

pengfeixx
Copy link
Contributor

@pengfeixx pengfeixx commented May 21, 2025

Fixed the issue that other account status was abnormal

Log: Fixed the issue that other account status was abnormal
pms: BUG-298649

Summary by Sourcery

Ensure login settings reflect the current account by refreshing them when the component loads or the userId changes

Bug Fixes:

  • Fix abnormal account status by updating auto-login and passwordless-login flags when switching accounts

Enhancements:

  • Extract settings update logic into an updateLoginSettings() function and invoke it on component completion and userId changes

Copy link

sourcery-ai bot commented May 21, 2025

Reviewer's Guide

Introduced a dedicated updateLoginSettings function to centralize auto-login and passwordless-login checks, and wired it to run on component initialization and whenever the userId changes, ensuring the account status is always reflected correctly in the UI.

File-Level Changes

Change Details Files
Centralized login-setting assignments and bound them to lifecycle events
  • Wrapped autoLogin and nopasswdLogin assignments inside updateLoginSettings()
  • Added Component.onCompleted handler to invoke updateLoginSettings() on load
  • Added onUserIdChanged handler to invoke updateLoginSettings() when userId updates
src/plugin-accounts/qml/AccountSettings.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pengfeixx - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Fixed the issue that other account status was abnormal

Log: Fixed the issue that other account status was abnormal
pms: BUG-298649
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • updateLoginSettings 函数在 Component.onCompletedonUserIdChanged 事件中被调用,确保了在组件加载和用户ID变化时更新登录设置。
  • settings.autoLoginCheckedsettings.nopasswdLoginChecked 的赋值直接使用了 dccData.autoLogindccData.nopasswdLogin 方法,假设这些方法已经正确实现。

是否建议立即修改:

  • 否,提交的代码没有明显的语法或逻辑错误。
  • 是,建议添加对 dccData.autoLogindccData.nopasswdLogin 方法的错误处理,以防止在方法调用失败时程序崩溃。
  • 是,建议添加注释说明 updateLoginSettings 函数的用途和实现细节,以提高代码的可读性和可维护性。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, pengfeixx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pengfeixx
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented May 21, 2025

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 442c1ff into linuxdeepin:master May 21, 2025
15 of 18 checks passed
@pengfeixx pengfeixx deleted the fix-298649 branch May 21, 2025 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants