-
Notifications
You must be signed in to change notification settings - Fork 136
fix: add wrap support for datetime spinboxes #2283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideEnabled wrap-around selection on all SpinboxEx components in DateTimeSettingDialog to improve date/time navigation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @wyu71 - I've reviewed your changes - here's some feedback:
- Consider defining wrap: true as a common default or via a style for SpinboxEx in this dialog to avoid repeating it on each component.
- Double-check month wrapping (e.g., 12 → 1) still updates the year and triggers updateDateMax on the day spinbox to prevent invalid dates.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Add wrap:true property to all SpinboxEx components in DateTimeSettingDialog for better date/time selection experience. Log: add wrap support for datetime spinboxes pms: BUG-282845
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: caixr23, wyu71 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deepin pr auto review关键摘要:
是否建议立即修改:
|
/forcemerge |
This pr force merged! (status: behind) |
Add wrap:true property to all SpinboxEx components in DateTimeSettingDialog for better date/time selection experience.
Log: add wrap support for datetime spinboxes
pms: BUG-282845
Summary by Sourcery
New Features: