fix: DNS “Click to save” prompt not displaying#3115
fix: DNS “Click to save” prompt not displaying#3115JWWTSL wants to merge 1 commit intolinuxdeepin:masterfrom
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRefactors the DccSettingsView Flickable layout by removing an intermediate Item wrapper, clipping directly on the Flickable, and making the central loader a direct child to fix coordinate/visibility issues such as the missing DNS “Click to save” prompt. Class diagram for updated DccSettingsView QML layoutclassDiagram
class Flickable_DccSettingsView {
bool scrollBarVisible
real contentHeight
bool clip
}
class ScrollBar_vertical {
int width
bool visible
}
class DccLoader_centralItem {
bool focus
Flickable_DccSettingsView dccObjItem
}
class DccLoader_bottomItem {
}
Flickable_DccSettingsView *-- ScrollBar_vertical : verticalScrollBar
Flickable_DccSettingsView *-- DccLoader_centralItem : centralItem
Flickable_DccSettingsView *-- DccLoader_bottomItem : bottomItem
%% Change summary
class RemovedWrapperItem {
bool clip
real y
real height
real width
}
RemovedWrapperItem <|-- DccLoader_centralItem : was_child_of
Flickable_DccSettingsView <|-- DccLoader_centralItem : now_child_of
Flow diagram for DccSettingsView Flickable clipping and layoutflowchart TD
A[Flickable_DccSettingsView clip true] --> B[centralItem is direct child of Flickable]
B --> C[contentHeight uses centralItem.height and bottomItem.height]
C --> D[Flickable handles scrolling and contentY internally]
D --> E[centralItem position stays in sync with scroll]
E --> F[UI elements like DNS Click_to_save remain inside clipped area]
F --> G[Prompt is visible to the user during scroll]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
log: Removed redundant `Item` wrappers from `DccSettingsView.qml`, set `clip: true` directly on the `Flickable`, and made `centralItem` a direct child of the `Flickable` to eliminate unnecessary coordinate offsets. pms: bug-353873
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JWWTSL, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
TAG Bot New tag: 6.1.78 |
|
TAG Bot New tag: 6.1.79 |
|
TAG Bot New tag: 6.1.80 |
|
TAG Bot New tag: 6.1.81 |
|
TAG Bot New tag: 6.1.82 |
|
TAG Bot New tag: 6.1.83 |
log: Removed redundant
Itemwrappers fromDccSettingsView.qml, setclip: truedirectly on theFlickable, and madecentralItema direct child of theFlickableto eliminate unnecessary coordinate offsets.pms: bug-353873
Summary by Sourcery
Bug Fixes: