Skip to content

fix: DNS “Click to save” prompt not displaying#3115

Open
JWWTSL wants to merge 1 commit intolinuxdeepin:masterfrom
JWWTSL:0319
Open

fix: DNS “Click to save” prompt not displaying#3115
JWWTSL wants to merge 1 commit intolinuxdeepin:masterfrom
JWWTSL:0319

Conversation

@JWWTSL
Copy link
Copy Markdown
Contributor

@JWWTSL JWWTSL commented Mar 23, 2026

log: Removed redundant Item wrappers from DccSettingsView.qml, set clip: true directly on the Flickable, and made centralItem a direct child of the Flickable to eliminate unnecessary coordinate offsets.

pms: bug-353873

Summary by Sourcery

Bug Fixes:

  • Ensure the DNS "Click to save" prompt is correctly displayed by fixing clipping and coordinate offset problems in the DccSettingsView flickable layout.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Mar 23, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactors the DccSettingsView Flickable layout by removing an intermediate Item wrapper, clipping directly on the Flickable, and making the central loader a direct child to fix coordinate/visibility issues such as the missing DNS “Click to save” prompt.

Class diagram for updated DccSettingsView QML layout

classDiagram
    class Flickable_DccSettingsView {
        bool scrollBarVisible
        real contentHeight
        bool clip
    }

    class ScrollBar_vertical {
        int width
        bool visible
    }

    class DccLoader_centralItem {
        bool focus
        Flickable_DccSettingsView dccObjItem
    }

    class DccLoader_bottomItem {
    }

    Flickable_DccSettingsView *-- ScrollBar_vertical : verticalScrollBar
    Flickable_DccSettingsView *-- DccLoader_centralItem : centralItem
    Flickable_DccSettingsView *-- DccLoader_bottomItem : bottomItem

    %% Change summary
    class RemovedWrapperItem {
        bool clip
        real y
        real height
        real width
    }

    RemovedWrapperItem <|-- DccLoader_centralItem : was_child_of
    Flickable_DccSettingsView <|-- DccLoader_centralItem : now_child_of
Loading

Flow diagram for DccSettingsView Flickable clipping and layout

flowchart TD
    A[Flickable_DccSettingsView clip true] --> B[centralItem is direct child of Flickable]
    B --> C[contentHeight uses centralItem.height and bottomItem.height]
    C --> D[Flickable handles scrolling and contentY internally]
    D --> E[centralItem position stays in sync with scroll]
    E --> F[UI elements like DNS Click_to_save remain inside clipped area]
    F --> G[Prompt is visible to the user during scroll]
Loading

File-Level Changes

Change Details Files
Simplified DccSettingsView Flickable structure and corrected central content anchoring to fix scrolling/visibility issues.
  • Set clip: true directly on the Flickable to constrain its visible area to the viewport.
  • Removed the redundant Item wrapper that previously offset content using contentY and its inverse.
  • Made the central DccLoader (centralItem) a direct child of the Flickable instead of the wrapper Item.
  • Updated dccObjItem from the wrapper Item to the Flickable control so downstream components use the correct coordinate and sizing context.
  • Preserved horizontal anchoring and margins for centralItem against the Flickable.
src/dde-control-center/plugin/DccSettingsView.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

log: Removed redundant `Item` wrappers from `DccSettingsView.qml`, set `clip: true` directly on the `Flickable`, and made `centralItem` a direct child of the `Flickable` to eliminate unnecessary coordinate offsets.

pms: bug-353873
@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JWWTSL, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link
Copy Markdown

deepin-bot Bot commented Mar 25, 2026

TAG Bot

New tag: 6.1.78
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #3130

@deepin-bot
Copy link
Copy Markdown

deepin-bot Bot commented Mar 30, 2026

TAG Bot

New tag: 6.1.79
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #3135

@deepin-bot
Copy link
Copy Markdown

deepin-bot Bot commented Apr 3, 2026

TAG Bot

New tag: 6.1.80
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #3153

@deepin-bot
Copy link
Copy Markdown

deepin-bot Bot commented Apr 9, 2026

TAG Bot

New tag: 6.1.81
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #3167

@deepin-bot
Copy link
Copy Markdown

deepin-bot Bot commented Apr 23, 2026

TAG Bot

New tag: 6.1.82
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #3187

@deepin-bot
Copy link
Copy Markdown

deepin-bot Bot commented Apr 24, 2026

TAG Bot

New tag: 6.1.83
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #3190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants