fix: resolve shortcut conflict UI state#3207
fix: resolve shortcut conflict UI state#3207MyLeeJiEun wants to merge 1 commit intolinuxdeepin:masterfrom
Conversation
1. Fixed shortcut conflict resolution by updating UI state after replacing conflicting keys 2. Added logic to hide conflict warning text and reset edit state when conflict is resolved 3. Ensured edit.keys is properly formatted after conflict resolution using dccData.formatKeys 4. Cleaned up trailing whitespace in ToolTip section for code consistency Log: Fixed shortcut conflict resolution UI state and warning display PMS: BUG-359143 Influence: 1. Test shortcut conflict detection and resolution workflow 2. Verify conflict warning message appears and disappears correctly 3. Test editing shortcuts when conflicts exist 4. Verify edit state resets properly after conflict resolution 5. Test that formatted keys display correctly after conflict resolution 6. Verify tooltip behavior with long shortcut names fix: 修复快捷键冲突的UI状态 1. 通过替换冲突键后更新UI状态来修复快捷键冲突解决 2. 添加逻辑以在解决冲突时隐藏冲突警告文本并重置编辑状态 3. 确保使用dccData.formatKeys在冲突解决后正确格式化edit.keys 4. 清理工具提示部分的尾随空白以保持代码一致性 Log: 修复快捷键冲突解决UI状态和警告显示 PMS: BUG-359143 Influence: 1. 测试快捷键冲突检测和解决工作流程 2. 验证冲突警告消息正确显示和消失 3. 测试存在冲突时编辑快捷键的功能 4. 验证冲突解决后编辑状态正确重置 5. 测试冲突解决后格式化键的正确显示 6. 验证长快捷键名称的工具提示行为
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MyLeeJiEun The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @MyLeeJiEun. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
CLA Assistant Lite bot: |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates shortcut conflict resolution behavior in the Shortcuts QML so that UI state, formatted keys, and warning visibility are correctly refreshed after conflicts are resolved, along with minor tooltip whitespace cleanup. Sequence diagram for resolving a shortcut conflict and updating UI statesequenceDiagram
actor User
participant MouseArea
participant edit
participant dccData
participant shortcutSettingsBody
participant conflictText
participant shortcutView
User->>MouseArea: click conflict resolution button
MouseArea->>shortcutSettingsBody: read conflictAccels
MouseArea->>edit: modifyShortcut(newAccels)
edit-->>MouseArea: shortcut updated
MouseArea->>shortcutSettingsBody: set conflictAccels = ""
MouseArea->>dccData: formatKeys(newAccels)
dccData-->>MouseArea: formattedKeys
MouseArea->>edit: set keys = formattedKeys
MouseArea->>conflictText: set visible = false
MouseArea->>shortcutView: set editItem = null
MouseArea->>shortcutView: set conflictText = null
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new onClicked handler is indented more deeply than surrounding code; aligning its indentation with nearby QML blocks would keep the file’s structure consistent and easier to read.
- When setting conflictText.visible and clearing shortcutView.editItem/shortcutView.conflictText, consider guarding against these references being undefined or null to avoid runtime errors if the UI structure changes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new onClicked handler is indented more deeply than surrounding code; aligning its indentation with nearby QML blocks would keep the file’s structure consistent and easier to read.
- When setting conflictText.visible and clearing shortcutView.editItem/shortcutView.conflictText, consider guarding against these references being undefined or null to avoid runtime errors if the UI structure changes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Log: Fixed shortcut conflict resolution UI state and warning display
PMS: BUG-359143
Influence:
fix: 修复快捷键冲突的UI状态
Log: 修复快捷键冲突解决UI状态和警告显示
PMS: BUG-359143
Influence:
Summary by Sourcery
Update shortcut conflict resolution to correctly refresh UI state and warning visibility after applying replacement shortcuts.
Bug Fixes:
Enhancements: