Skip to content

sync: from linuxdeepin/dtkdeclarative#280

Merged
18202781743 merged 1 commit intomasterfrom
sync-pr-508-nosync
Aug 8, 2025
Merged

sync: from linuxdeepin/dtkdeclarative#280
18202781743 merged 1 commit intomasterfrom
sync-pr-508-nosync

Conversation

@deepin-ci-robot
Copy link
Copy Markdown
Contributor

@deepin-ci-robot deepin-ci-robot commented Aug 7, 2025

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#508

Summary by Sourcery

Enhancements:

  • Define normalDark property equal to normal color for warningButton text palette in FlowStyle.qml

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#508
@deepin-ci-robot
Copy link
Copy Markdown
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Aug 7, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR synchronizes Qt6 QML styling definitions from the upstream linuxdeepin/dtkdeclarative repository by introducing a new alias for the warning button palette to ensure consistent dark mode behavior.

Class diagram for updated FlowStyle warningButton palette

classDiagram
    class FlowStyle {
        +QtObject warningButton
    }
    class warningButton {
        +D.Palette text
    }
    class D.Palette {
        +normal : color
        +normalDark : color
    }
    FlowStyle --> warningButton : contains
    warningButton --> D.Palette : uses
Loading

File-Level Changes

Change Details Files
Added 'normalDark' property alias in warningButton palette
  • Declared new property 'normalDark' and set it equal to existing 'normal' color value
qt6/src/qml/FlowStyle.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link
Copy Markdown
Contributor Author

deepin pr auto review

关键摘要:

  • 新增的 normalDark 属性直接引用了 normal 属性,这可能不是预期的行为,需要确认是否这是有意为之。

是否建议立即修改:

  • 是,需要确认新增的 normalDark 属性是否应该与 normal 属性相同,如果是,则不需要修改;如果不是,则需要提供正确的颜色值。

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @deepin-ci-robot - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@18202781743 18202781743 merged commit 0502604 into master Aug 8, 2025
14 of 15 checks passed
@18202781743 18202781743 deleted the sync-pr-508-nosync branch August 8, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants