sync: from linuxdeepin/dtkdeclarative#283
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-ci-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR pulls in updates from linuxdeepin/dtkdeclarative by refactoring FlowStyle.qml’s overlay colors: it standardizes on Qt.rgba for all states, adds missing dark-mode variants, and tweaks alpha levels for greater consistency. Class diagram for updated FlowStyle.qml Palette structureclassDiagram
class FlowStyle {
<<QtObject>>
background1 : D.Palette
highlight : D.Palette
}
class D.Palette {
normal
normalDark
hovered
hoveredDark
pressed
pressedDark
disabled
}
FlowStyle --> D.Palette
D.Palette : common
D.Palette : crystal
%% Highlighted changes:
D.Palette : hoveredDark
D.Palette : pressedDark
%% hoveredDark and pressedDark added to both background1 and highlight
%% All color values now use Qt.rgba
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @deepin-ci-robot - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#511
fdc8adb to
8b8577e
Compare
deepin pr auto review代码审查意见:
综合以上意见,建议对代码进行重构,以提高代码的可读性、可维护性和一致性。 |
|
TAG Bot New tag: 6.0.41 |
|
TAG Bot New tag: 6.0.42 |
Synchronize source files from linuxdeepin/dtkdeclarative.
Source-pull-request: linuxdeepin/dtkdeclarative#511
Summary by Sourcery
Update FlowStyle.qml to standardize color definitions and enhance theming consistency by using Qt.rgba, adjusting opacity values, and adding dark-mode variants for hovered and pressed states.
Enhancements: