sync: from linuxdeepin/dtkdeclarative

[deepin-ci-robot]

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#512

Summary by Sourcery

Sync source files from linuxdeepin/dtkdeclarative and refine icon scaling logic to ensure consistent device pixel ratio updates and URL refreshing.

Enhancements:

• Unconditionally update device pixel ratio during DQuickIconImage initialization
• Simplify pixmapChange logic to trigger URL update solely based on device pixel ratio changes

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[deepin-ci-robot]

deepin pr auto review

代码审查意见：

1. 代码格式和可读性：

   • 在DQuickIconImagePrivate::init()函数中，注释和代码的顺序被调整了，这有助于提高代码的可读性。建议保持这种格式，使代码更加清晰。

2. 逻辑和功能：

   • 在DQuickIconImagePrivate::init()函数中，updateDevicePixelRatio(1.0)被注释掉了，但在DQuickIconImage::pixmapChange()函数中又被重新启用。如果这是有意为之，应该添加相应的注释说明为什么需要这样做。如果这是无意的，应该撤销这一更改。
   • 在DQuickIconImage::pixmapChange()函数中，updateDevicePixelRatio(1.0)的调用被移到了条件判断内部，这可能会改变原有的逻辑。如果这是为了确保在特定条件下才更新缩放比例，应该添加注释说明原因。

3. 性能：

   • 没有明显的性能问题，但建议在updateDevicePixelRatio函数中添加性能优化的注释，例如是否需要缓存计算结果。

4. 安全性：

   • 代码中没有涉及到安全性问题，如SQL注入、XSS等。

5. 其他建议：

   • 在DQuickIconImagePrivate::init()函数中，maybeUpdateUrl()的调用应该放在updateDevicePixelRatio之后，以确保在缩放比例更新后再更新URL。
   • 在DQuickIconImage::pixmapChange()函数中，d->maybeUpdateUrl()的调用应该放在updateDevicePixelRatio之后，以确保在缩放比例更新后再更新URL。

综上所述，代码的格式和可读性得到了改善，但需要确认逻辑和功能是否正确，并确保性能和安全性。

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR syncs changes from linuxdeepin/dtkdeclarative by removing iconType checks so that updateDevicePixelRatio() and maybeUpdateUrl() are unconditionally called, simplifying icon scaling and refresh logic.

Sequence diagram for updated icon scaling and refresh logic in pixmapChange()

sequenceDiagram
    participant DQuickIconImage
    participant DQuickIconImagePrivate

    DQuickIconImage->>DQuickIconImagePrivate: updateDevicePixelRatio(1.0)
    alt Device pixel ratio updated
        DQuickIconImagePrivate->>DQuickIconImagePrivate: maybeUpdateUrl()
    end
    DQuickIconImage->>QQuickImage: pixmapChange()

Loading

Class diagram for updated DQuickIconImage and DQuickIconImagePrivate methods

classDiagram
    class DQuickIconImagePrivate {
        +void init()
        +bool updateDevicePixelRatio(double ratio)
        +void maybeUpdateUrl()
        -iconType
    }
    class DQuickIconImage {
        +void pixmapChange()
    }
    DQuickIconImagePrivate <|-- DQuickIconImage

    %% Highlight method changes
    %% updateDevicePixelRatio and maybeUpdateUrl are now called unconditionally in both init() and pixmapChange()

Loading

File-Level Changes

Change	Details	Files
Unconditionally update device pixel ratio during initialization	Removed ThemeIconName guard around updateDevicePixelRatio() in init() Preserved signal connection for theme changes after ratio update	src/private/dquickiconimage.cpp
Always refresh URL based on new pixel ratio in pixmapChange	Dropped iconType check before calling updateDevicePixelRatio() Triggered maybeUpdateUrl() whenever updateDevicePixelRatio() returns true	src/private/dquickiconimage.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @deepin-ci-robot - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}