fix: incorrect padding for MenuItem

[18202781743]

MenuItem display is incomplete because padding is too enough.

pms: TASK-368399

Summary by Sourcery

Bug Fixes:

• Correct the padding logic for menu items to properly handle cases with indicators and submenus, ensuring consistent content positioning

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes an issue where the MenuItem display was incomplete due to insufficient padding. The padding logic has been adjusted to ensure proper display of menu items.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Adjusted left and right padding calculations for MenuItem to ensure sufficient padding is applied, taking into account indicator and arrow padding.	Modified leftPadding to use the maximum value between contentPadding and indicatorPadding when not mirrored, otherwise use arrowPadding. Modified rightPadding to use the maximum value between contentPadding and indicatorPadding when mirrored, otherwise use arrowPadding.	qt6/src/qml/MenuItem.qml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

deepin pr auto review

关键摘要:

• 代码修改中使用了 Math.max 函数来确保 indicatorPadding 和 DS.Style.menu.item.contentPadding 之间的值不会小于 DS.Style.menu.item.contentPadding，这是一个合理的改动，可以避免负值 padding 的情况。

是否建议立即修改:

• 否，这次提交的修改看起来是合理的，没有发现需要立即修改的问题。但是，建议进行进一步的测试以确保这些更改不会引入新的问题，并且与现有的 UI 设计保持一致。

[sourcery-ai]

Hey @18202781743 - I've reviewed your changes - here's some feedback:

Overall Comments:

• It's great you're addressing the padding issue, but can you provide a visual example or test case to ensure the fix works as expected across different scenarios?

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment