Skip to content

fix: health score retention#3932

Merged
gaspergrom merged 2 commits intomainfrom
fix/health-score-retention
Mar 23, 2026
Merged

fix: health score retention#3932
gaspergrom merged 2 commits intomainfrom
fix/health-score-retention

Conversation

@gaspergrom
Copy link
Contributor

@gaspergrom gaspergrom commented Mar 19, 2026

Note

Medium Risk
Changes the filtering logic used to compute health score retention, which can materially alter retention metrics and downstream health scores. Low implementation risk, but impacts analytics outputs used for product/business decisions.

Overview
Fixes health score retention calculations by additionally filtering both current- and previous-quarter member cohorts to only include activities whose (type, platform) appears in activityTypes_filtered.

This aligns retention with the same activity-type/platform inclusion rules used elsewhere, potentially changing computed retention rates and benchmarks for affected segments.

Written by Cursor Bugbot for commit 7f45419. This will update automatically on new commits. Configure here.

Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
@gaspergrom gaspergrom requested review from Copilot and joanagmaia and removed request for Copilot March 19, 2026 09:44
@github-actions
Copy link
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

2 similar comments
@github-actions
Copy link
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@github-actions
Copy link
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

Copilot AI review requested due to automatic review settings March 23, 2026 17:04
@gaspergrom gaspergrom merged commit 25e438e into main Mar 23, 2026
5 of 6 checks passed
@gaspergrom gaspergrom deleted the fix/health-score-retention branch March 23, 2026 17:04
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Tinybird retention health-score computation to only consider activities whose (type, platform) pairs are allowed by activityTypes_filtered, bringing retention in line with other activity-filtered health score metrics.

Changes:

  • Added (type, platform) IN (SELECT activityType, platform FROM activityTypes_filtered) filtering to the current quarter cohort query.
  • Added the same filtering to the previous quarter cohort query.
  • Applied the filtering consistently in both the project-scoped datasource branch and the *_bucket_union branch.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

skwowet pushed a commit that referenced this pull request Mar 25, 2026
Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants