Conversation
Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
2 similar comments
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
|
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
There was a problem hiding this comment.
Pull request overview
Updates the Tinybird retention health-score computation to only consider activities whose (type, platform) pairs are allowed by activityTypes_filtered, bringing retention in line with other activity-filtered health score metrics.
Changes:
- Added
(type, platform) IN (SELECT activityType, platform FROM activityTypes_filtered)filtering to the current quarter cohort query. - Added the same filtering to the previous quarter cohort query.
- Applied the filtering consistently in both the
project-scoped datasource branch and the*_bucket_unionbranch.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Gašper Grom <gasper.grom@gmail.com> Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Note
Medium Risk
Changes the filtering logic used to compute health score retention, which can materially alter retention metrics and downstream health scores. Low implementation risk, but impacts analytics outputs used for product/business decisions.
Overview
Fixes health score retention calculations by additionally filtering both current- and previous-quarter member cohorts to only include activities whose
(type, platform)appears inactivityTypes_filtered.This aligns retention with the same activity-type/platform inclusion rules used elsewhere, potentially changing computed retention rates and benchmarks for affected segments.
Written by Cursor Bugbot for commit 7f45419. This will update automatically on new commits. Configure here.