Skip to content

fix: loguru import error #3956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
epipav merged 1 commit into from
Mar 25, 2026
Merged

fix: loguru import error #3956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions services/apps/git_integration/src/crowdgit/services/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
import re
from urllib.parse import urlparse

import loguru

from crowdgit.errors import (
CommandExecutionError,
CommandTimeoutError,
Expand Down Expand Up @@ -169,7 +167,7 @@ async def run_shell_command(
cwd: str = None,
timeout: float | None = None,
input_text: str | bytes | None = None,
stderr_logger: loguru.Logger | None = None,
stderr_logger=None,
stderr_log_level: str = "INFO",
Comment on lines +170 to 171
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stderr_logger lost its type annotation to avoid importing loguru, which fixes the runtime import issue but removes typing from an otherwise well-typed API. Suggest keeping typing without a runtime dependency by using from __future__ import annotations plus a TYPE_CHECKING import, or by defining a small Protocol/type alias for the expected logger interface (e.g., an object with .log(level: str, message: str)), and update the docstring to match the actual .log(...) usage (it currently mentions .info()).

Copilot uses AI. Check for mistakes.
) -> str:
"""
Expand Down
Loading