Skip to content

Footer error implementation #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaspergrom merged 4 commits into from
Mar 13, 2025
Merged

Footer error implementation #101

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1990af4
Footer error implementation
gaspergrom Mar 13, 2025
8534b1d
Merge branch 'main' into improvement/footer-issues
gaspergrom Mar 13, 2025
f90f96a
fix: importing footer for client
asithade Mar 13, 2025
61dc060
Remove debug logs
gaspergrom Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions frontend/app/error.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@
</nuxt-link>
</div>
</div>
<pre class="whitespace-pre-wrap">
{{error}}
</pre>
</div>
</main>
</template>
Expand Down
9 changes: 7 additions & 2 deletions frontend/app/layouts/default.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,19 @@
<lfx-navbar />
<slot />
<lfx-toast theme="dark" />
<client-only>
<lfx-footer class="px-10 mx-auto max-w-3xl pb-6 pt-6" />
</client-only>
</main>
<!-- <lfx-footer />-->
</template>

<script setup lang="ts">
import LfxNavbar from '~/components/shared/layout/navbar.vue';
import LfxToast from '~/components/uikit/toast/toast.vue';
// import '@linuxfoundation/lfx-ui-core';
// Only import the UI core library on the client side
if (import.meta.client) {
await import('@linuxfoundation/lfx-ui-core');
}
</script>

<style lang="scss" scoped>
Expand Down
2 changes: 1 addition & 1 deletion frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"storybook:build": "storybook build"
},
"dependencies": {
"@linuxfoundation/lfx-ui-core": "^0.0.12",
"@linuxfoundation/lfx-ui-core": "^0.0.14",
"@nuxt/eslint": "^0.7.5",
"@pinia/nuxt": "0.9.0",
"@primevue/themes": "^4.2.5",
Expand Down
10 changes: 5 additions & 5 deletions frontend/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.