Skip to content

[INS-243] Fix fetching collection projects count from TinyBird#123

Merged
borfast merged 1 commit intomainfrom
bugfix/fix-collection-projects-list
Mar 20, 2025
Merged

[INS-243] Fix fetching collection projects count from TinyBird#123
borfast merged 1 commit intomainfrom
bugfix/fix-collection-projects-list

Conversation

@borfast
Copy link
Copy Markdown
Contributor

@borfast borfast commented Mar 19, 2025

The TinyBird query to fetch the total projects count was missing a couple of parameters.

Linear ticket.

Summary by CodeRabbit

  • New Features
    • Enhanced project count filtering with additional options for more refined results.

@borfast borfast added the bug Something isn't working label Mar 19, 2025
@borfast borfast requested review from emlimlf and gaspergrom March 19, 2025 11:41
@borfast borfast self-assigned this Mar 19, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 19, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This update extends the functionality in the project count API by adding two parameters (collectionSlug and isLf) to the fetchFromTinybird function call in frontend/server/api/project/index.ts. The additional parameters are sent with requests to the /v0/pipes/projects_list.json endpoint to enable more precise filtering of project data based on specific collections and the "lf" category. The existing error handling and control flow remain unchanged, and no modifications were made to exported or public entities.

Changes

File Change Summary
frontend/server/api/project/index.ts Added collectionSlug and isLf parameters to the fetchFromTinybird function call for enhanced project filtering.

Possibly related PRs

Suggested reviewers

  • gaspergrom

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 19c7f0601152424f7da5528ed9b0cf20b21a511e and c13c4a5.

📒 Files selected for processing (1)
  • frontend/server/api/project/index.ts (1 hunks)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

…n detail page

Signed-off-by: Raúl Santos <4837+borfast@users.noreply.github.com>
@borfast borfast force-pushed the bugfix/fix-collection-projects-list branch from 19c7f06 to c13c4a5 Compare March 20, 2025 10:48
@borfast borfast merged commit ca2992d into main Mar 20, 2025
2 of 3 checks passed
@borfast borfast deleted the bugfix/fix-collection-projects-list branch March 20, 2025 10:49
@borfast borfast assigned borfast and unassigned borfast May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants