Conversation
The itx-poll and itx-poll-vote v1-objects events are now handled by the lfx-v2-voting-service, making these handlers redundant. Removes handlers_voting.go, models_voting.go, and the corresponding routing cases in handlers.go to eliminate duplicate indexer and FGA messages. Generated with [Claude Code](https://claude.ai/claude-code) Signed-off-by: Andres Tobon <andrest2455@gmail.com>
The itx-surveys and itx-survey-responses v1-objects events are now handled by the lfx-v2-survey-service, making these handlers redundant. Removes handlers_survey.go, models_surveys.go, and the corresponding routing cases in handlers.go to eliminate duplicate indexer and FGA messages. Generated with [Claude Code](https://claude.ai/claude-code) Signed-off-by: Andres Tobon <andrest2455@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes voting and survey ingestion from lfx-v1-sync-helper now that those DynamoDB event streams are handled by dedicated v2 services, preventing duplicate indexer/FGA messages.
Changes:
- Deleted voting handler/model implementations (
handlers_voting.go,models_voting.go). - Deleted survey handler/model implementations (
handlers_survey.go,models_surveys.go). - Removed
itx-poll*anditx-survey*routing cases fromhandleKVPutinhandlers.go.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| cmd/lfx-v1-sync-helper/models_voting.go | Removed voting data models and custom unmarshaling logic. |
| cmd/lfx-v1-sync-helper/models_surveys.go | Removed survey data models and custom unmarshaling logic. |
| cmd/lfx-v1-sync-helper/handlers_voting.go | Removed vote / vote-response KV handlers and NATS indexer/FGA publishers. |
| cmd/lfx-v1-sync-helper/handlers_survey.go | Removed survey / survey-response KV handlers and NATS indexer/FGA publishers. |
| cmd/lfx-v1-sync-helper/handlers.go | Removed routing for voting/survey KV prefixes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Voting and survey KV events are now handled by lfx-v2-voting-service and lfx-v2-survey-service respectively. Add explicit no-op cases in both handleKVPut and handleResourceDelete to log a debug message and return, consistent with how other delegated handlers are treated. Generated with [Claude Code](https://claude.ai/claude-code) Signed-off-by: Andres Tobon <andrest2455@gmail.com>
jordane
approved these changes
Mar 12, 2026
emsearcy
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handlers_voting.goandmodels_voting.go— voting events (itx-poll,itx-poll-vote) are now handled bylfx-v2-voting-servicehandlers_survey.goandmodels_surveys.go— survey events (itx-surveys,itx-survey-responses) are now handled bylfx-v2-survey-servicehandlers.goto eliminate duplicate indexer and FGA messagesTicket
🤖 Generated with Claude Code