Conversation
…rade - Assign JoinMode as string value (not pointer) in CreateCommitteePayload - Remove JoinMode assignment from UpdateCommitteeBasePayload (field not available) - Pass all 23 endpoints to committeeservice.NewClient (added invite, application, join, leave endpoints) - Bump lfx-v2-committee-service to v0.2.22 and lfx-v2-indexer-service to v0.4.16 Generated with [Claude Code](https://claude.ai/claude-code) Signed-off-by: Andres Tobon <andrest2455@gmail.com>
Adds a GitHub Actions workflow that builds and publishes container images for both lfx-v1-sync-helper and dynamodb-stream-consumer on pull requests targeting main, tagged with the commit SHA and branch name. Generated with [Claude Code](https://claude.ai/claude-code) Signed-off-by: Andres Tobon <andrest2455@gmail.com>
![github-license-compliance[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
Updates this service to compile against lfx-v2-committee-service v0.2.22 (and related dependency bumps) and adds a GitHub Actions workflow to build/publish PR-branch container images when PRs target main.
Changes:
- Bump
lfx-v2-committee-serviceto v0.2.22 andlfx-v2-indexer-serviceto v0.4.16. - Adjust committee payload mapping/client initialization to match updated committee-service client APIs.
- Add
publish-branch.yamlworkflow to publish PR branch images.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
go.mod |
Updates committee/indexer service dependency versions and tidies indirect deps. |
go.sum |
Records new module checksums for the updated dependencies. |
cmd/lfx-v1-sync-helper/lfx_v2_client.go |
Extends committee-service client initialization to include additional endpoints required by the new SDK. |
cmd/lfx-v1-sync-helper/handlers_committees.go |
Updates committee create/update payload mapping to match breaking API changes. |
.github/workflows/publish-branch.yaml |
Introduces PR-to-main workflow to build and publish branch-tagged images. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -412,7 +412,7 @@ func mapV1DataToCommitteeCreatePayload(ctx context.Context, v1Data map[string]an | |||
|
|
|||
| // Map governance fields (requires lfx-v2-committee-service >= v0.3.0 with PR #61 merged). | |||
| @@ -489,10 +489,7 @@ func mapV1DataToCommitteeUpdateBasePayload(ctx context.Context, committeeUID str | |||
| // UpdateCommitteeBasePayload does not support BusinessEmailRequired field. | |||
|
|
|||
| // Map governance fields (requires lfx-v2-committee-service >= v0.3.0 with PR #61 merged). | |||
| env: | ||
| HEAD_REF: "${{ github.head_ref }}" | ||
| run: | | ||
| container_tag=$(echo "$HEAD_REF" | sed 's/[^_0-9a-zA-Z]/-/g' | cut -c -127) |
Comment on lines
+42
to
+45
| BUILD_TIME=$(date -u '+%Y-%m-%d_%H:%M:%S') | ||
| export BUILD_TIME | ||
| GIT_COMMIT=${GIT_COMMIT:0:7} | ||
| export GIT_COMMIT |
Comment on lines
+57
to
+60
| BUILD_TIME=$(date -u '+%Y-%m-%d_%H:%M:%S') | ||
| export BUILD_TIME | ||
| GIT_COMMIT=${GIT_COMMIT:0:7} | ||
| export GIT_COMMIT |
mauriciozanettisalomao
approved these changes
Mar 17, 2026
| @@ -0,0 +1,66 @@ | |||
| # Copyright The Linux Foundation and each contributor to LFX. | |||
Contributor
There was a problem hiding this comment.
(not a blocker) If you want to keep the same name as project, committee, and meeting service, I think you can rename it to ko-build-branch.yaml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lfx-v2-committee-servicev0.2.22: correctJoinModeassignment type, remove unavailable field fromUpdateCommitteeBasePayload, and pass all 23 endpoints tocommitteeservice.NewClientpublish-branch.yamlGitHub Actions workflow to build and publish container images for both binaries on PRs targeting mainTicket
LFXV2-1283
🤖 Generated with Claude Code