fix: add replicas configuration for KV buckets#70
Open
AlanSherman wants to merge 1 commit intomainfrom
Open
Conversation
Signed-off-by: Alan Sherman <asherman@linuxfoundation.org>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds explicit replicas configuration for the JetStream KeyValue (KV) buckets managed by the lfx-v1-sync-helper Helm chart, allowing KV bucket replication factor to be set via chart values.
Changes:
- Added
natsResources.*.replicasdefaults for the three KV buckets invalues.yaml. - Rendered the
spec.replicasfield for those KeyValue resources in the Helm template.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
charts/lfx-v1-sync-helper/values.yaml |
Introduces default replicas: 1 values for each KV bucket. |
charts/lfx-v1-sync-helper/templates/nats-resources.yaml |
Emits spec.replicas for each KeyValue resource using the configured values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
jordane
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.