Skip to content

LFXV2-872: Tie chart releases to app releases #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrest50 merged 2 commits into from
Mar 2, 2026
Merged

LFXV2-872: Tie chart releases to app releases #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b36480d
Tie chart releases to app releases
emsearcy Feb 4, 2026
f0922df
Merge branch 'main' of ssh://github.com/linuxfoundation/lfx-v2-auth-s…
andrest50 Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ko-build-tag.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
set -euo pipefail
APP_VERSION=$(echo ${{ github.ref_name }} | sed 's/v//g')
CHART_NAME="$(yq '.name' charts/*/Chart.yaml)"
CHART_VERSION="$(yq '.version' charts/*/Chart.yaml)"
CHART_VERSION=$(echo ${{ github.ref_name }} | sed 's/v//g')
{
echo "app_version=$APP_VERSION"
echo "chart_name=$CHART_NAME"
Expand Down Expand Up @@ -87,7 +87,7 @@ jobs:
- name: Publish Chart to GHCR
id: publish-ghcr
# yamllint disable-line rule:line-length
uses: linuxfoundation/lfx-public-workflows/.github/actions/helm-chart-oci-publisher@c465d6571fa0b8be9d551d902955164ea04a00af # main
uses: linuxfoundation/lfx-public-workflows/.github/actions/helm-chart-oci-publisher@17e4144d7ba68f7c3e8c16eece5aed15fd7c2dc8 # main
with:
name: ${{ needs.publish.outputs.chart_name }}
repository: ${{ github.repository }}/chart
Expand Down
4 changes: 3 additions & 1 deletion charts/lfx-v2-auth-service/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,7 @@ apiVersion: v2
name: lfx-v2-auth-service
description: LFX Platform V2 Auth Service chart
type: application
version: 0.3.5
# This version should not be incremented, as it is dynamically replaced with the release version during the chart build
# job.
version: 0.0.1
Comment on lines +8 to +10
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README.md documentation is now outdated and contradicts these changes. Lines 153-154 and 190-191 instruct users to manually update the chart version in Chart.yaml before releases, but this PR changes the approach so that the chart version is now dynamically set to match the release tag. The documentation should be updated to reflect this new workflow where the chart version should not be manually incremented.

Copilot uses AI. Check for mistakes.
appVersion: "latest"