[LFXV2-932] Restrict Committee Member Email Visibility for Non-Privileged Users

cmd/committee-api/design/committee.go

@@ -349,7 +349,7 @@ var _ = dsl.Service("committee-service", func() {
 		})
 
 		dsl.Result(func() {
-			dsl.Attribute("member", CommitteeMemberFullWithReadonlyAttributes)
+			dsl.Attribute("member", CommitteeMemberBasicWithReadonlyAttributes)
 			ETagAttribute()
 			dsl.Required("member")
 		})

cmd/committee-api/design/type.go

@@ -384,14 +384,18 @@ func AuditorsAttribute() {
 // CommitteeMemberBase is the DSL type for a committee member base.
 var CommitteeMemberBase = dsl.Type("committee-member-base", func() {
 	dsl.Description("A base representation of committee members.")
-
 	CommitteeMemberBaseAttributes()
 })
 
+// CommitteeMemberSensitive is the DSL type for a committee member sensitive information.
+var CommitteeMemberSensitive = dsl.Type("committee-member-sensitive", func() {
+	dsl.Description("Sensitive information of a committee member.")
+	CommitteeMemberSensitiveAttributes()
+})
+
 // CommitteeMemberBaseAttributes defines the base attributes for a committee member.
 func CommitteeMemberBaseAttributes() {
 	UsernameAttribute()
-	EmailAttribute()
 	FirstNameAttribute()
 	LastNameAttribute()
 	JobTitleAttribute()
@@ -403,11 +407,30 @@ func CommitteeMemberBaseAttributes() {
 	OrganizationInfoAttributes()
 }
 
+// CommitteeMemberSensitiveAttributes defines the sensitive attributes for a committee member.
+func CommitteeMemberSensitiveAttributes() {
+	EmailAttribute()
+}
+
 // CommitteeMemberFull is the DSL type for a complete committee member.
 var CommitteeMemberFull = dsl.Type("committee-member-full", func() {
 	dsl.Description("A complete representation of committee members with all attributes.")
 
 	CommitteeMemberBaseAttributes()
+	CommitteeMemberSensitiveAttributes()
+})
+
+// CommitteeMemberBasicWithReadonlyAttributes is the DSL type for a basic committee member with readonly attributes.
+var CommitteeMemberBasicWithReadonlyAttributes = dsl.Type("committee-member-basic-with-readonly-attributes", func() {
+	dsl.Description("A basic representation of committee members with readonly attributes.")
+
+	CommitteeMemberUIDAttribute()
+	CommitteeUIDMemberAttribute()
+	CommitteeNameMemberAttribute()
+	CommitteeCategoryMemberAttribute()
+	CommitteeMemberBaseAttributes()
+	CreatedAtAttribute()
+	UpdatedAtAttribute()
 })
 
 // CommitteeMemberFullWithReadonlyAttributes is the DSL type for a complete committee member with readonly attributes.
@@ -419,18 +442,21 @@ var CommitteeMemberFullWithReadonlyAttributes = dsl.Type("committee-member-full-
 	CommitteeNameMemberAttribute()
 	CommitteeCategoryMemberAttribute()
 	CommitteeMemberBaseAttributes()
+	CommitteeMemberSensitiveAttributes()
 	CreatedAtAttribute()
 	UpdatedAtAttribute()
 })
 
 // CommitteeMemberCreateAttributes defines attributes for creating a committee member.
 func CommitteeMemberCreateAttributes() {
 	CommitteeMemberBaseAttributes()
+	CommitteeMemberSensitiveAttributes()
 }
 
 // CommitteeMemberUpdateAttributes defines attributes for updating a committee member.
 func CommitteeMemberUpdateAttributes() {
 	CommitteeMemberBaseAttributes()
+	CommitteeMemberSensitiveAttributes()
 }
 
 // Organization Information Attributes

cmd/committee-api/service/committee_service.go

@@ -251,7 +251,8 @@ func (s *committeeServicesrvc) GetCommitteeMember(ctx context.Context, p *commit
 	}
 
 	// Convert domain model to GOA response
-	result := s.convertMemberDomainToFullResponse(committeeMember)
+	// Only basic info, no sensitive data
+	result := s.convertMemberDomainBasicResponse(committeeMember)
 
 	// Create result with ETag (using revision from NATS)
 	revisionStr := fmt.Sprintf("%d", revision)

cmd/committee-api/service/committee_service_response.go

@@ -323,10 +323,12 @@ func (s *committeeServicesrvc) convertMemberPayloadToDomain(p *committeeservice.
 	member := &model.CommitteeMember{
 		CommitteeMemberBase: model.CommitteeMemberBase{
 			CommitteeUID: p.UID,
-			Email:        p.Email,
 			AppointedBy:  p.AppointedBy,
 			Status:       p.Status,
 		},
+		CommitteeMemberSensitive: model.CommitteeMemberSensitive{
+			Email: p.Email,
+		},
 	}
 
 	// Handle Username with nil check
@@ -407,10 +409,12 @@ func (s *committeeServicesrvc) convertPayloadToUpdateMember(p *committeeservice.
 		CommitteeMemberBase: model.CommitteeMemberBase{
 			UID:          p.MemberUID, // Member UID is required for updates
 			CommitteeUID: p.UID,       // Committee UID from path parameter
-			Email:        p.Email,
 			AppointedBy:  p.AppointedBy,
 			Status:       p.Status,
 		},
+		CommitteeMemberSensitive: model.CommitteeMemberSensitive{
+			Email: p.Email,
+		},
 	}
 
 	// Handle Username with nil check
@@ -486,9 +490,10 @@ func (s *committeeServicesrvc) convertMemberDomainToFullResponse(member *model.C
 		return nil
 	}
 
+	memberUID := member.UID
 	result := &committeeservice.CommitteeMemberFullWithReadonlyAttributes{
 		CommitteeUID: &member.CommitteeUID,
-		UID:          &member.UID,
+		UID:          &memberUID,
 		Email:        &member.Email,
 		AppointedBy:  member.AppointedBy,
 		Status:       member.Status,
@@ -585,3 +590,54 @@ func (s *committeeServicesrvc) convertMemberDomainToFullResponse(member *model.C
 
 	return result
 }
+
+// convertMemberDomainBasicResponse converts domain CommitteeMember to GOA basic response type
+func (s *committeeServicesrvc) convertMemberDomainBasicResponse(member *model.CommitteeMember) *committeeservice.CommitteeMemberBasicWithReadonlyAttributes {
+	if member == nil {
+		return nil
+	}
+
+	memberUID := member.UID
+	result := &committeeservice.CommitteeMemberBasicWithReadonlyAttributes{
+		CommitteeUID: &member.CommitteeUID,
+		UID:          &memberUID,
+		AppointedBy:  member.AppointedBy,
+		Status:       member.Status,
+	}
+
+	// Only set optional fields if they have values
+	if member.Username != "" {
+		result.Username = &member.Username
+	}
+	if member.FirstName != "" {
+		result.FirstName = &member.FirstName
+	}
+	if member.LastName != "" {
+		result.LastName = &member.LastName
+	}
+	if member.JobTitle != "" {
+		result.JobTitle = &member.JobTitle
+	}
+	if member.LinkedInProfile != "" {
+		result.LinkedinProfile = &member.LinkedInProfile
+	}
+	if member.CommitteeName != "" {
+		result.CommitteeName = &member.CommitteeName
+	}
+	if member.CommitteeCategory != "" {
+		result.CommitteeCategory = &member.CommitteeCategory
+	}
+
+	// Convert timestamps to strings if they exist
+	if !member.CreatedAt.IsZero() {
+		createdAt := member.CreatedAt.Format("2006-01-02T15:04:05Z07:00")
+		result.CreatedAt = &createdAt
+	}
+
+	if !member.UpdatedAt.IsZero() {
+		updatedAt := member.UpdatedAt.Format("2006-01-02T15:04:05Z07:00")
+		result.UpdatedAt = &updatedAt
+	}
+
+	return result
+}