Skip to content

Add Chart.yaml version comment for dynamic replacement #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emsearcy merged 2 commits into from
Feb 19, 2026
+1 −0
Merged

Add Chart.yaml version comment for dynamic replacement #108

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10d4669
Add Chart.yaml version comment for dynamic replacement
emsearcy Feb 3, 2026
5d5197b
Merge branch 'main' into LFXV2-872-chart-version-comments
emsearcy Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/lfx-platform/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ apiVersion: v2
name: lfx-platform
description: LFX Platform v2 Helm chart
type: application
# This version should not be incremented, as it is dynamically replaced with the release version during the chart build job.
version: 0.0.1
Comment on lines +8 to 9
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment added in Chart.yaml states that the version should not be incremented and will be dynamically replaced during the chart build job. However, this contradicts the existing documentation in README.md (lines 112-113 and 135-136) which instructs developers to manually update the chart version in Chart.yaml. If the version is now dynamically replaced during the build process, the README.md should be updated to reflect this new workflow and remove instructions about manually updating the chart version.

Copilot uses AI. Check for mistakes.
icon: https://github.com/linuxfoundation/lfx-v2-helm/raw/main/img/lfx-logo-color.svg
dependencies:
Expand Down