Skip to content

Fix Typo on heimdall env: OTEL_TRACES_EXPORTER#110

Merged
bramwelt merged 1 commit intomainfrom
bramwelt/traces-exporter-values
Feb 17, 2026
Merged

Fix Typo on heimdall env: OTEL_TRACES_EXPORTER#110
bramwelt merged 1 commit intomainfrom
bramwelt/traces-exporter-values

Conversation

@bramwelt
Copy link
Contributor

Fixes a typo on the OTEL_TRACES_EXPORTER environment variable name.

Signed-off-by: Trevor Bramwell tbramwell@linuxfoundation.org

Fixes a typo on the OTEL_TRACES_EXPORTER environment variable name.

Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
@bramwelt bramwelt requested review from a team and emsearcy as code owners February 13, 2026 18:40
Copilot AI review requested due to automatic review settings February 13, 2026 18:40
@coderabbitai
Copy link

coderabbitai bot commented Feb 13, 2026

Walkthrough

A single environment variable is renamed in the Helm chart's values configuration for Heimdall's OpenTelemetry tracing setup, changing OTEL_TRACE_EXPORTER to OTEL_TRACES_EXPORTER while preserving all other tracing settings.

Changes

Cohort / File(s) Summary
Configuration Update
charts/lfx-platform/values.yaml
Renamed OpenTelemetry environment variable from OTEL_TRACE_EXPORTER to OTEL_TRACES_EXPORTER in Heimdall's tracing configuration. OTLP/GRPC protocol and endpoint settings remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing a typo in the OTEL_TRACES_EXPORTER environment variable name in the Heimdall configuration.
Description check ✅ Passed The description is directly related to the changeset, explaining that it fixes a typo on the OTEL_TRACES_EXPORTER environment variable name.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bramwelt/traces-exporter-values

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects an OpenTelemetry environment variable name in the Helm values for the Heimdall deployment, ensuring tracing exporter configuration is picked up by the OpenTelemetry SDK as intended.

Changes:

  • Rename OTEL_TRACE_EXPORTEROTEL_TRACES_EXPORTER under heimdall.env in charts/lfx-platform/values.yaml.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bramwelt bramwelt merged commit 148bf19 into main Feb 17, 2026
10 checks passed
@bramwelt bramwelt deleted the bramwelt/traces-exporter-values branch February 17, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants