Skip to content

add simple member type and relationships#113

Merged
jordane merged 1 commit intomainfrom
jme/member-service-model
Mar 5, 2026
Merged

add simple member type and relationships#113
jordane merged 1 commit intomainfrom
jme/member-service-model

Conversation

@jordane
Copy link
Member

@jordane jordane commented Mar 5, 2026

This is needed for a very early member service that Nirav has drafted

Copilot AI review requested due to automatic review settings March 5, 2026 16:36
@jordane jordane requested review from a team and emsearcy as code owners March 5, 2026 16:36
@coderabbitai
Copy link

coderabbitai bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 41ef020f-1845-4102-bed0-10bf82a77961

📥 Commits

Reviewing files that changed from the base of the PR and between eff81ee and b268c3a.

📒 Files selected for processing (1)
  • charts/lfx-platform/templates/openfga/model.yaml

Walkthrough

Added a new public member type to the OpenFGA authorization model in the Helm chart template, introducing an auditor relation that references user and team#member for membership and indexing use; no existing types or relations were modified.

Changes

Cohort / File(s) Summary
OpenFGA Authorization Model
charts/lfx-platform/templates/openfga/model.yaml
Appended a new type member with a single relation auditor: [user, team#member] and explanatory comments; small addition (+6/-0 lines) that augments the authorization schema without changing existing types.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title accurately reflects the main change: adding a simple member type and relationships to the openfga model.
Description check ✅ Passed The description is related to the changeset, explaining that the member type and relationships are needed for a member service.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jme/member-service-model

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@charts/lfx-platform/templates/openfga/model.yaml`:
- Around line 339-343: The model added a new type named "member" but the model
version remains at 9.0.0; bump the model's semantic version major component to
the next major (e.g., 10.0.0) in the model.yaml header so the addition of type
member is a breaking/versioned change; locate the model version declaration (the
"version" field near the top of model.yaml) and update it accordingly while
leaving the new "type member" block and its "relations" unchanged.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b32e7a06-e63d-4306-afdd-5d8d8390ffff

📥 Commits

Reviewing files that changed from the base of the PR and between 223082c and eff81ee.

📒 Files selected for processing (1)
  • charts/lfx-platform/templates/openfga/model.yaml

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

andrest50
andrest50 previously approved these changes Mar 5, 2026
This is needed for a very early member service that Nirav has drafted

Signed-off-by: Jordan Evans <jevans@linuxfoundation.org>
@jordane jordane merged commit f7097a9 into main Mar 5, 2026
4 checks passed
@jordane jordane deleted the jme/member-service-model branch March 5, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants