Skip to content

Move to shared service chart #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlanSherman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move to shared service chart #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions charts/lfx-v2-meeting-service/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,14 @@
# SPDX-License-Identifier: MIT
---
apiVersion: v2
name: lfx-v2-meeting-service
description: LFX Platform V2 Meeting Service chart
name: lfx-one-meeting-service
description: LFX one Meeting Service chart
type: application
version: 0.4.16
version: 2.0.0
appVersion: "latest"

dependencies:
- name: lfx-service
version: 1.0.0
repository: file://../../../lfx-v2-helm/charts/lfx-service
# repository: oci://ghcr.io/linuxfoundation/lfx-service/chart
Comment on lines +12 to +15
Copy link

@coderabbitai coderabbitai bot Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Fix the dependency repository path — it currently escapes the repo.

file://../../../lfx-v2-helm/charts/lfx-service climbs three levels up from charts/lfx-v2-meeting-service, so Helm will look for the dependency outside this repository and helm dependency build will fail in CI/packaging. Point the file URL at the actual in-repo location (two .. segments from here) or switch to the published OCI repo.

-    repository: file://../../../lfx-v2-helm/charts/lfx-service
+    repository: file://../../lfx-v2-helm/charts/lfx-service
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- name: lfx-service
version: 1.0.0
repository: file://../../../lfx-v2-helm/charts/lfx-service
# repository: oci://ghcr.io/linuxfoundation/lfx-service/chart
- name: lfx-service
version: 1.0.0
repository: file://../../lfx-v2-helm/charts/lfx-service
# repository: oci://ghcr.io/linuxfoundation/lfx-service/chart
🤖 Prompt for AI Agents 
In charts/lfx-v2-meeting-service/Chart.yaml around lines 12 to 15, the
dependency repository path climbs three levels
(file://../../../lfx-v2-helm/charts/lfx-service) which escapes the repo and
breaks helm dependency build in CI; update the repository to point to the
in-repo location using two parent segments
(file://../../lfx-v2-helm/charts/lfx-service) or replace it with the published
OCI URL (oci://ghcr.io/linuxfoundation/lfx-service/chart) so Helm resolves the
dependency within the repository.

56 changes: 0 additions & 56 deletions charts/lfx-v2-meeting-service/templates/deployment.yaml
View file
Open in desktop

This file was deleted.

35 changes: 0 additions & 35 deletions charts/lfx-v2-meeting-service/templates/heimdall-middleware.yaml
View file
Open in desktop

This file was deleted.

51 changes: 0 additions & 51 deletions charts/lfx-v2-meeting-service/templates/httproute.yaml
View file
Open in desktop

This file was deleted.

135 changes: 0 additions & 135 deletions charts/lfx-v2-meeting-service/templates/nats-kv-buckets.yaml
View file
Open in desktop

This file was deleted.

Loading
Loading