fix: add replicas configuration for KV buckets#48
Conversation
Signed-off-by: Alan Sherman <asherman@linuxfoundation.org>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThe changes add replica configurations for NATS KeyValue buckets in the Helm chart. The template now includes replica field specifications for project base and settings buckets, with corresponding default values of 1 configured in the values file. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
There was a problem hiding this comment.
Pull request overview
Adds configurable JetStream KV bucket replica count to the lfx-v2-project-service Helm chart so deployments can control KV redundancy.
Changes:
- Introduces
replicasvalues for thekv_bucket_project_baseandkv_bucket_project_settingsbuckets. - Renders the
replicasfield into the JetStreamKeyValueCRs created by the chart.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/lfx-v2-project-service/values.yaml | Adds replicas defaults for both KV bucket configurations. |
| charts/lfx-v2-project-service/templates/nats-kv-buckets.yaml | Passes the configured replicas value into each KeyValue resource spec. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
No description provided.