Skip to content

fix: add replicas configuration for KV buckets#48

Open
AlanSherman wants to merge 1 commit intomainfrom
asherman/nats-replicas
Open

fix: add replicas configuration for KV buckets#48
AlanSherman wants to merge 1 commit intomainfrom
asherman/nats-replicas

Conversation

@AlanSherman
Copy link
Contributor

No description provided.

Signed-off-by: Alan Sherman <asherman@linuxfoundation.org>
@AlanSherman AlanSherman requested a review from a team as a code owner March 18, 2026 23:01
Copilot AI review requested due to automatic review settings March 18, 2026 23:01
@coderabbitai
Copy link

coderabbitai bot commented Mar 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7085070b-7e88-41f3-bc5e-700709fd0fcb

📥 Commits

Reviewing files that changed from the base of the PR and between a77df30 and 2ea4c2f.

📒 Files selected for processing (2)
  • charts/lfx-v2-project-service/templates/nats-kv-buckets.yaml
  • charts/lfx-v2-project-service/values.yaml

Walkthrough

The changes add replica configurations for NATS KeyValue buckets in the Helm chart. The template now includes replica field specifications for project base and settings buckets, with corresponding default values of 1 configured in the values file.

Changes

Cohort / File(s) Summary
NATS KV Bucket Replication Configuration
charts/lfx-v2-project-service/templates/nats-kv-buckets.yaml, charts/lfx-v2-project-service/values.yaml
Added replicas field to two KeyValue resources in the template, referencing values from nats.kv\_bucket\_project\_base and nats.kv\_bucket\_project\_settings. Configured default replica count of 1 for both KV bucket types in values.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess relevance to the changeset. Add a description explaining why replicas configuration was added and what the intended impact is on KV bucket behavior.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding replicas configuration for KV buckets, which matches the changeset modifications to nats-kv-buckets.yaml and values.yaml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch asherman/nats-replicas
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds configurable JetStream KV bucket replica count to the lfx-v2-project-service Helm chart so deployments can control KV redundancy.

Changes:

  • Introduces replicas values for the kv_bucket_project_base and kv_bucket_project_settings buckets.
  • Renders the replicas field into the JetStream KeyValue CRs created by the chart.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
charts/lfx-v2-project-service/values.yaml Adds replicas defaults for both KV bucket configurations.
charts/lfx-v2-project-service/templates/nats-kv-buckets.yaml Passes the configured replicas value into each KeyValue resource spec.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants