Skip to content

feat(ci): tie chart releases to app releases #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrest50 merged 2 commits into from
Mar 2, 2026
+9 −7
Merged

feat(ci): tie chart releases to app releases #31

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81f3f8c
feat(ci): tie chart releases to app releases
emsearcy Feb 4, 2026
2d2a130
Merge branch 'main' of ssh://github.com/linuxfoundation/lfx-v2-query-…
andrest50 Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/ko-build-tag.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,15 @@ jobs:
chart_version: ${{ steps.prepare.outputs.chart_version }}
steps:
- name: Checkout repository
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline comment spacing here is ... # v4 with only one space before #. With .yamllint extending the default rules, this typically violates the comments rule (min 2 spaces before an inline comment). Use two spaces before # (see .github/workflows/mega-linter.yml:28 for the existing style).

Copilot uses AI. Check for mistakes.

- name: Prepare versions and chart name
id: prepare
run: |
set -euo pipefail
APP_VERSION=$(echo ${{ github.ref_name }} | sed 's/v//g')
CHART_NAME="$(yq '.name' charts/*/Chart.yaml)"
CHART_VERSION="$(yq '.version' charts/*/Chart.yaml)"
CHART_VERSION=$(echo ${{ github.ref_name }} | sed 's/v//g')
Comment on lines 37 to +39
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using sed 's/v//g' removes every "v" in the tag (e.g., v1.2.3-dev becomes 1.2.3-de), which can produce incorrect/invalid versions. Strip only a leading v (e.g., s/^v// or bash ${ref#v}) and consider reusing APP_VERSION for CHART_VERSION to avoid divergence.

Copilot uses AI. Check for mistakes.
Comment on lines 36 to +39
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the run script, ${{ github.ref_name }} is interpolated directly into the shell command without quotes. If a tag name contains shell metacharacters (e.g., $()), it could be interpreted by bash. Prefer using the runner-provided env var ($GITHUB_REF_NAME) and quote it (or assign it once) before processing, so it’s treated strictly as data.

Copilot uses AI. Check for mistakes.
Comment on lines 37 to +39
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Strip only a leading “v” to avoid mangling version strings.

sed 's/v//g' removes every “v”, not just the prefix. Use a leading-only strip and reuse APP_VERSION for CHART_VERSION to avoid accidental changes.

🔧 Proposed fix 
-          APP_VERSION=$(echo ${{ github.ref_name }} | sed 's/v//g')
+          APP_VERSION=$(echo ${{ github.ref_name }} | sed 's/^v//')
           CHART_NAME="$(yq '.name' charts/*/Chart.yaml)"
-          CHART_VERSION=$(echo ${{ github.ref_name }} | sed 's/v//g')
+          CHART_VERSION="$APP_VERSION"
🤖 Prompt for AI Agents 
In @.github/workflows/ko-build-tag.yaml around lines 37 - 39, The pipeline
currently strips all "v" characters using sed 's/v//g' which can mangle version
strings; update the APP_VERSION assignment to only remove a leading "v" (e.g.,
use a leading-anchor sed like s/^v//) and set CHART_VERSION by reusing
APP_VERSION instead of re-running sed, keeping CHART_NAME logic unchanged.

{
echo "app_version=$APP_VERSION"
echo "chart_name=$CHART_NAME"
Expand Down Expand Up @@ -75,12 +75,12 @@ jobs:
image_name: ${{ steps.publish-ghcr.outputs.image_name }}
steps:
- name: Checkout repository
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline comment spacing here is ... # v4 with only one space before #. With .yamllint extending the default rules, this typically violates the comments rule (min 2 spaces before an inline comment). Use two spaces before # (consistent with other workflows like .github/workflows/mega-linter.yml:28).

Copilot uses AI. Check for mistakes.

- name: Publish Chart to GHCR
id: publish-ghcr
# yamllint disable-line rule:line-length
uses: linuxfoundation/lfx-public-workflows/.github/actions/helm-chart-oci-publisher@c465d6571fa0b8be9d551d902955164ea04a00af # main
uses: linuxfoundation/lfx-public-workflows/.github/actions/helm-chart-oci-publisher@17e4144d7ba68f7c3e8c16eece5aed15fd7c2dc8 # main
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline comment spacing here is ... # main with only one space before #. With .yamllint extending the default rules, this typically violates the comments rule (min 2 spaces before an inline comment). Adjust to two spaces before # to match repo style and avoid linter findings.

Copilot uses AI. Check for mistakes.
with:
name: ${{ needs.publish.outputs.chart_name }}
repository: ${{ github.repository }}/chart
Expand All @@ -91,12 +91,12 @@ jobs:
registry_password: ${{ secrets.GITHUB_TOKEN }}

- name: Install Cosign
uses: sigstore/cosign-installer@d58896d6a1865668819e1d91763c7751a165e159 # v3.9.2
uses: sigstore/cosign-installer@d58896d6a1865668819e1d91763c7751a165e159 # v3.9.2
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline comment spacing here is ... # v3.9.2 with only one space before #. With .yamllint extending the default rules, this typically violates the comments rule (min 2 spaces before an inline comment). Use two spaces before # to avoid yamllint warnings/errors.

Copilot uses AI. Check for mistakes.
with:
cosign-release: "${{ env.COSIGN_VERSION }}"

- name: Login to GitHub
uses: docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772 # v3.4.0
uses: docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772 # v3.4.0
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline comment spacing here is ... # v3.4.0 with only one space before #. With .yamllint extending the default rules, this typically violates the comments rule (min 2 spaces before an inline comment). Use two spaces before # to match the linting configuration.

Copilot uses AI. Check for mistakes.
with:
registry: ghcr.io
username: ${{ github.actor }}
Expand Down
4 changes: 3 additions & 1 deletion charts/lfx-v2-query-service/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,7 @@ apiVersion: v2
name: lfx-v2-query-service
description: LFX Platform V2 Query Service chart
type: application
version: 0.4.10
# This version should not be incremented, as it is dynamically replaced with the release version during the chart build
# job.
version: 0.0.1
appVersion: "latest"